Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 04/01/2014 09:33 PM, Markus Armbruster wrote:
> Chen Gang <gang.chen.5i5j@gmail.com> writes:
> 
>> On 04/01/2014 04:13 PM, Markus Armbruster wrote:
>>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>>
>>>> On 03/31/2014 11:49 PM, Markus Armbruster wrote:
>>>>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>>>>
>>>>>> in get_boot_device()
>>>>>>
>>>>>>  - remove 'res' to simplify code
>>>>>>
>>>>>> in main():
>>>>>>
>>>>>>  - remove useless 'continue'.
>>>>>>
>>>>>>  - in main switch():
>>>>>>
>>>>>>    - remove or adjust all useless 'break'.
>>>>>>
>>>>>>    - remove useless '{' and '}'.
>>>>>>
>>>>>>  - use assignment directly to replace useless 'args'
>>>>>>    (which is defined in the middle of code block).
>>>>>
>>>>> Suggest to have one patch per item in this list.
>>>>>
>>>>
>>>> OK, thanks. I will/should send again in this week (within 2014-04-06).
>>>
>>> No rush :)
>>>
>>
>> Yeah, more discussions, and more thinking of, before implementations.
> 
> What I meant to say is "next week is fine, we're not in a big hurry to
> get this done".
> 

OK, thanks. :-)


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed