From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 1/2] libxl: Set guest parameters from config
 file during a restore
Date: Tue, 01 Apr 2014 09:45:01 -0400
Message-ID: <533AC2DD.1000900@oracle.com>
References: <1396148751-6918-1-git-send-email-boris.ostrovsky@oracle.com>
	<1396148751-6918-2-git-send-email-boris.ostrovsky@oracle.com>
	<1396348627.8667.91.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1396348627.8667.91.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: kevin.tian@intel.com, suravee.suthikulpanit@amd.com, stefano.stabellini@eu.citrix.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, jun.nakajima@intel.com
List-Id: xen-devel@lists.xenproject.org

On 04/01/2014 06:37 AM, Ian Campbell wrote:
> On Sat, 2014-03-29 at 23:05 -0400, Boris Ostrovsky wrote:
>> @@ -484,22 +506,11 @@ static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
>>   
>>       xc_get_hvm_param(handle, domid, HVM_PARAM_STORE_PFN, store_mfn);
>>       xc_get_hvm_param(handle, domid, HVM_PARAM_CONSOLE_PFN, console_mfn);
>> -    xc_set_hvm_param(handle, domid, HVM_PARAM_PAE_ENABLED,
>> -                     libxl_defbool_val(info->u.hvm.pae));
>> -#if defined(__i386__) || defined(__x86_64__)
>> -    xc_set_hvm_param(handle, domid, HVM_PARAM_VIRIDIAN,
>> -                     libxl_defbool_val(info->u.hvm.viridian));
>> -    xc_set_hvm_param(handle, domid, HVM_PARAM_HPET_ENABLED,
>> -                     libxl_defbool_val(info->u.hvm.hpet));
>> -#endif
>> -    xc_set_hvm_param(handle, domid, HVM_PARAM_TIMER_MODE, timer_mode(info));
>> -    xc_set_hvm_param(handle, domid, HVM_PARAM_VPT_ALIGN,
>> -                     libxl_defbool_val(info->u.hvm.vpt_align));
>> -    xc_set_hvm_param(handle, domid, HVM_PARAM_NESTEDHVM,
>> -                     libxl_defbool_val(info->u.hvm.nested_hvm));
>>       xc_set_hvm_param(handle, domid, HVM_PARAM_STORE_EVTCHN, store_evtchn);
>>       xc_set_hvm_param(handle, domid, HVM_PARAM_CONSOLE_EVTCHN, console_evtchn);
>>   
>> +    hvm_set_conf_params(handle, domid, info);
> Can you confirm that this isn't now called twice on domain create, once
> from libxl__build_pre and then again here.

No, I can't.

I thought I checked that libxl__build_pre() is not called on create and 
of course it clearly is. So this was me being rather sloppy.

I'll remove hvm_set_conf_params() call from hvm_build_set_params() and 
leave it only in libxl__build_pre().

-boris