From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUzyo-0000R5-Ce for qemu-devel@nongnu.org; Tue, 01 Apr 2014 10:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUzyj-000654-Dy for qemu-devel@nongnu.org; Tue, 01 Apr 2014 10:47:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUzyj-00064o-4o for qemu-devel@nongnu.org; Tue, 01 Apr 2014 10:47:53 -0400 Message-ID: <533AD194.8030806@redhat.com> Date: Tue, 01 Apr 2014 08:47:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140331191631.21034.25433.stgit@fimbulvetr.bsc.es> <20140331191648.21034.9744.stgit@fimbulvetr.bsc.es> <5339C950.8060308@redhat.com> <87ob0lrwl7.fsf@fimbulvetr.bsc.es> In-Reply-To: <87ob0lrwl7.fsf@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vRoHrabQmvusH9U6ovOnJAUHptup6ouhq" Subject: Re: [Qemu-devel] [PATCH v6 3/4] qapi: Add a primitive to include other files from a QAPI schema file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Luiz Capitulino , Markus Armbruster , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vRoHrabQmvusH9U6ovOnJAUHptup6ouhq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/01/2014 07:46 AM, Llu=C3=ADs Vilanova wrote: >> The formatting in Beno=C3=AEt's series was a little nicer aestheticall= y: >=20 >> +Inclusion loop detected with file: multi_file_loop_include.json >> +Path to the broken include is: >> + multi_file_loop_include.json >> + multi_loop.json >=20 >> Furthermore, it had the benefit of using the spelling provided by the >> user, rather than the absolute path to the files. You want to track >> canonical paths for detecting the loop, but do NOT want to report >> absolute paths back to the user - instead, it's nicer to report back t= he >> names as they spelled it. >=20 > I think it's better reporting absolute paths, otherwise the user has to= mentally > keep track of the relative paths to get to the file. If you display the entire chain of paths that you opened as spelled by the user, the user shouldn't have that hard a time finding the right file. Furthermore, I seriously doubt we will be including files from very many subdirectories in our use of this feature - the error is there to aid a developer adding a new include, and won't ever trigger in normal usage. If a developer triggers the error, they KNOW that the error was caused by the very file that they were working on. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vRoHrabQmvusH9U6ovOnJAUHptup6ouhq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTOtGUAAoJEKeha0olJ0NqHxkIAKgb89dm2ogiNvComoZ5xlPP Furuz+lOQQIGicCXNiDQIiKmWO+Lc83DmUJhgV7vySUnjVIy50TuxHrIc9Q0QrZA nZexr13UTijn3R9nzhDriv5Dk3lHEuPsnMB+h8+b90xm1X+ZhvyWxq33JjwgrZXs SQ0XT69YzNTXnqxxOC5WiogdFVJ/l+Fu/9N14dnmu584raFGeaiPzdvY5wh9NSIM AJstFkgo5D3dw3QU1p1qDAvtME1WIY5ej2oa9OFPZHFtAdt5EZnEmqVyl1SccgK2 9u8yrprS5t1Z5EgnnhTPVTzitNtqC/3CSwyAVLa8JPmXL/feky+VOujkQJMQIJs= =l/ya -----END PGP SIGNATURE----- --vRoHrabQmvusH9U6ovOnJAUHptup6ouhq--