All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shijoe George <spanjikk@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [libnfsidmapd PATCH] nss: use strrchr() instead of strchr() to get the last occurrence of "@"
Date: Tue, 01 Apr 2014 21:27:30 +0530	[thread overview]
Message-ID: <533AE1EA.4030103@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Issues with AD/IPA Trust works & how SSSD deals with AD users.

Lets say we have a IPA domain linux.example.com & AD domain 
win.example.com, We setup IPA/AD trust so that Windows domain users can 
login into Linux, When we setup AD Trust with IPA, AD users login as 
username@AD_REALM, With our example above, username will be 
"user@win.example.com" Without @win.example.com that user will be 
searched only in IPA domain not in AD domain. That is the reason @DOMAIN 
part is important in SSSD when dealing with IPA-AD trust.

With current behaviour the client-side code is stripping the domain off 
based on the location of the first "@" character in the value returned 
by the server. This results in UID/GID mappings failing and resulting in 
ownership on the clients as "nobody".

With the provided patch, we can accept fully qualified usernames.

[-- Attachment #2: nss.patch --]
[-- Type: text/x-patch, Size: 607 bytes --]

commit 7ff76ddf2e37d595732d9c8e534de8aa530eb57a
Author: Shijoe Panjikkaran <spanjikk@redhat.com>
Date:   Tue Apr 1 20:53:54 2014 +0530

    nss: strrchr() instead of strchr() to get the last occurrence of "@"
    
    Signed-off-by: Shijoe Panjikkaran <spanjikk@redhat.com>

diff --git a/nss.c b/nss.c
index b2b1227..f8129fe 100644
--- a/nss.c
+++ b/nss.c
@@ -135,7 +135,7 @@ static char *strip_domain(const char *name, const char *domain)
 	char *l = NULL;
 	int len;
 
-	c = strchr(name, '@');
+	c = strrchr(name, '@');
 	if (c == NULL && domain != NULL)
 		goto out;
 	if (c == NULL && domain == NULL) {

             reply	other threads:[~2014-04-01 15:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 15:57 Shijoe George [this message]
2014-04-30 17:24 ` [libnfsidmapd PATCH] nss: use strrchr() instead of strchr() to get the last occurrence of "@" Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533AE1EA.4030103@redhat.com \
    --to=spanjikk@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.