From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v8 18/20] xenctx: Add 16 bit output Date: Tue, 01 Apr 2014 14:53:11 -0400 Message-ID: <533B0B17.3060800@terremark.com> References: <1395947147-5262-1-git-send-email-dslutz@verizon.com> <1395947147-5262-19-git-send-email-dslutz@verizon.com> <1396362326.8667.211.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396362326.8667.211.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Don Slutz Cc: George Dunlap , Stefano Stabellini , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/01/14 10:25, Ian Campbell wrote: > On Thu, 2014-03-27 at 15:05 -0400, Don Slutz wrote: >> @@ -1043,7 +1046,9 @@ static void dump_ctx(int vcpu) >> } >> if ( xenctx.do_stack ) >> { >> - print_stack(&ctx, vcpu, guest_word_size, xenctx.stk_addr); >> + print_stack(&ctx, vcpu, >> + !guest_protected_mode ? 2 : guest_word_size, > Doesn't this indicate that guest_word_size is set wrongly in the ! > guest_protected_mode case? I guess so, will fix it there. -Don Slutz > Ian. >