From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>
Cc: Gleb Natapov <gleb@redhat.com>, Peter Anvin <hpa@zytor.com>,
Jan Hubicka <hubicka@ucw.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Jaroslav Kysela <perex@perex.cz>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] x86 LTO changes for v3.15
Date: Tue, 01 Apr 2014 11:54:23 -0700 [thread overview]
Message-ID: <533B0B5F.2040907@linux.intel.com> (raw)
In-Reply-To: <CA+55aFxCCOASxhgRfGmNRPgHwZQJ2Q0Oa9-vwpMdmTqx99m26g@mail.gmail.com>
On 03/31/2014 05:33 PM, Linus Torvalds wrote:
>
> I notice that there seems to be a handful of x86 system calls that
> don't use the SYSCALL_DEFINEx() macros to define the system call, some
> grepping finds at least ioperm(), modify_ldt(), sigreturn() and
> rt_sigreturn(). There are probably others. They should just be
> converted to SYSCALL_DEFINEx() while at it. No, x86 doesn't need the
> typecasting, but it won't hurt either, and it's good to be consistent.
>
> I'm not sure why those system calls didn't get converted (other
> x86-specific ones like vm86() _have_ gotten converted), maybe there's
> some reason for it. But I *think* the reason is "nobody noticed".
>
Pretty much. If nothing else, it breaks tracing.
-hpa
next prev parent reply other threads:[~2014-04-01 19:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 21:05 [GIT PULL] x86 LTO changes for v3.15 H. Peter Anvin
2014-03-31 21:54 ` Linus Torvalds
2014-03-31 23:03 ` Andi Kleen
2014-04-01 0:17 ` Linus Torvalds
2014-04-01 0:33 ` Linus Torvalds
2014-04-01 18:54 ` H. Peter Anvin [this message]
2014-04-01 19:15 ` Linus Torvalds
2014-04-01 19:43 ` H. Peter Anvin
2014-04-02 0:01 ` Steven Rostedt
2014-04-02 0:35 ` Linus Torvalds
2014-04-02 12:33 ` Steven Rostedt
2014-04-02 17:10 ` H. Peter Anvin
2014-04-02 17:59 ` Steven Rostedt
2014-04-01 1:09 ` Andi Kleen
2014-04-01 1:35 ` H. Peter Anvin
2014-04-01 2:26 ` Linus Torvalds
2014-04-01 20:49 ` Paul Bolle
2014-04-01 23:17 ` Andi Kleen
2014-04-02 8:29 ` Paul Bolle
2014-04-16 8:53 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533B0B5F.2040907@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=hubicka@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.