From: Peter Lieven <pl@kamp.de>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCHv2] block: optimize zero writes with bdrv_write_zeroes
Date: Tue, 01 Apr 2014 22:38:09 +0200 [thread overview]
Message-ID: <533B23B1.1040903@kamp.de> (raw)
In-Reply-To: <53359B12.3030008@redhat.com>
Am 28.03.2014 16:53, schrieb Eric Blake:
> On 03/28/2014 08:46 AM, Peter Lieven wrote:
>> this patch tries to optimize zero write requests
>> by automatically using bdrv_write_zeroes if it is
>> supported by the format.
>>
>> This significantly speeds up file system initialization and
>> should speed zero write test used to test backend storage
>> performance.
>>
>> block.c | 39 ++++++++++++++++++++++++++++++++++++++-
>> include/block/block_int.h | 12 ++++++++++++
>> include/qemu-common.h | 1 +
>> qemu-options.hx | 6 ++++++
>> util/iov.c | 21 +++++++++++++++++++++
>> 5 files changed, 78 insertions(+), 1 deletion(-)
>>
> Is there any QMP query- command that can expose the current setting of
> this value? Is this something worth making changeable during runtime?
> Is it something that can be requested per-disk at hotplug time?
currently there is no qmp query command I would add it to "query-block" if
noone has objections.
I don't think that its needed to change this at runtime.
Setting it at hotplug time is, of course, reasonable.
I will look at this and send a respin.
Thanks for the suggestions,
Peter
next prev parent reply other threads:[~2014-04-01 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 14:46 [Qemu-devel] [PATCHv2] block: optimize zero writes with bdrv_write_zeroes Peter Lieven
2014-03-28 15:53 ` Eric Blake
2014-04-01 20:38 ` Peter Lieven [this message]
2014-04-01 7:33 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533B23B1.1040903@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.