All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.com>
Cc: peter.maydell@linaro.org, aliguori@amazon.com, aik@ozlabs.ru,
	jan.kiszka@siemens.com,
	Prasad Joshi <prasadjoshi.linux@gmail.com>,
	riku.voipio@iki.fi, agraf@suse.de, v.maffione@gmail.com,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org, av1474@comtv.ru,
	stefanha@redhat.com, pbonzini@redhat.com,
	g.lettieri@iet.unipi.it, alex@alex.org.uk, rizzo@iet.unipi.it,
	kraxel@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function
Date: Wed, 02 Apr 2014 12:53:34 +0200	[thread overview]
Message-ID: <533BEC2E.2050802@suse.de> (raw)
In-Reply-To: <533BD03A.7070405@suse.com>

Am 02.04.2014 10:54, schrieb Alexander Graf:
> 
> On 24.03.14 15:25, Andreas Färber wrote:
>> Am 23.03.2014 10:28, schrieb Prasad Joshi:
>>> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
>>> ---
>>>   hw/intc/openpic_kvm.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> Thanks for spotting this, applied to ppc-next (w/ typo fix in subject):
>> https://github.com/afaerber/qemu-cpu/commits/ppc-next
> 
> This patch breaks the e500 platform target.

Ouch. I had specifically tested build and -M pseries on PowerKVM but
obviously did not for e500.

Means it was theoretically broken from the start then, if you compare my
extended commit message:

http://git.qemu.org/?p=qemu.git;a=commit;h=6f1834a2baa2f2688efaa7756d000876c7898d13

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.com>
Cc: peter.maydell@linaro.org, aliguori@amazon.com, aik@ozlabs.ru,
	jan.kiszka@siemens.com,
	Prasad Joshi <prasadjoshi.linux@gmail.com>,
	riku.voipio@iki.fi, agraf@suse.de, v.maffione@gmail.com,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org, av1474@comtv.ru,
	chouteau@adacore.com, stefanha@redhat.com, pbonzini@redhat.com,
	g.lettieri@iet.unipi.it, alex@alex.org.uk, rizzo@iet.unipi.it,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function
Date: Wed, 02 Apr 2014 12:53:34 +0200	[thread overview]
Message-ID: <533BEC2E.2050802@suse.de> (raw)
In-Reply-To: <533BD03A.7070405@suse.com>

Am 02.04.2014 10:54, schrieb Alexander Graf:
> 
> On 24.03.14 15:25, Andreas Färber wrote:
>> Am 23.03.2014 10:28, schrieb Prasad Joshi:
>>> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
>>> ---
>>>   hw/intc/openpic_kvm.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> Thanks for spotting this, applied to ppc-next (w/ typo fix in subject):
>> https://github.com/afaerber/qemu-cpu/commits/ppc-next
> 
> This patch breaks the e500 platform target.

Ouch. I had specifically tested build and -M pseries on PowerKVM but
obviously did not for e500.

Means it was theoretically broken from the start then, if you compare my
extended commit message:

http://git.qemu.org/?p=qemu.git;a=commit;h=6f1834a2baa2f2688efaa7756d000876c7898d13

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2014-04-02 10:54 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23  9:28 [Qemu-trivial] [PATCH 1/6] audio: set top level latch for each slot Prasad Joshi
2014-03-23  9:28 ` [Qemu-devel] " Prasad Joshi
2014-03-23  9:28 ` [Qemu-trivial] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function Prasad Joshi
2014-03-23  9:28   ` [Qemu-devel] " Prasad Joshi
2014-03-24 14:25   ` [Qemu-trivial] " Andreas Färber
2014-03-24 14:25     ` Andreas Färber
2014-04-02  8:54     ` [Qemu-trivial] " Alexander Graf
2014-04-02  8:54       ` Alexander Graf
2014-04-02 10:53       ` Andreas Färber [this message]
2014-04-02 10:53         ` Andreas Färber
2014-04-02 11:32         ` [Qemu-trivial] " Alexander Graf
2014-04-02 11:32           ` Alexander Graf
2014-03-23  9:28 ` [Qemu-trivial] [PATCH 3/6] pcnet: remove duplicate assignment Prasad Joshi
2014-03-23  9:28   ` [Qemu-devel] " Prasad Joshi
2014-03-24 13:18   ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-24 13:18     ` [Qemu-devel] " Stefan Hajnoczi
2014-03-25 12:32   ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-25 12:32     ` Stefan Hajnoczi
2014-03-23  9:28 ` [Qemu-trivial] [PATCH 4/6] hw/timer/grlib_gptimer: remove unnecessary assignment Prasad Joshi
2014-03-23  9:28   ` [Qemu-devel] " Prasad Joshi
2014-03-27  5:16   ` [Qemu-trivial] " Michael Tokarev
2014-03-27  5:16     ` [Qemu-devel] " Michael Tokarev
2014-03-23  9:28 ` [Qemu-trivial] [PATCH 5/6] linux-user: remove duplicate statement Prasad Joshi
2014-03-23  9:28   ` [Qemu-devel] " Prasad Joshi
2014-03-24  8:57   ` [Qemu-trivial] " Riku Voipio
2014-03-24  8:57     ` [Qemu-devel] " Riku Voipio
2014-03-27  5:17   ` [Qemu-trivial] " Michael Tokarev
2014-03-27  5:17     ` [Qemu-devel] " Michael Tokarev
2014-03-23  9:28 ` [Qemu-trivial] [PATCH 6/6] net: netmap_poll must update both read/write poll state Prasad Joshi
2014-03-23  9:28   ` [Qemu-devel] " Prasad Joshi
2014-03-24 13:18   ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-24 13:18     ` [Qemu-devel] " Stefan Hajnoczi
2014-03-25 12:31   ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-25 12:31     ` Stefan Hajnoczi
2014-03-24 13:19 ` [Qemu-trivial] [PATCH 1/6] audio: set top level latch for each slot Stefan Hajnoczi
2014-03-24 13:19   ` [Qemu-devel] " Stefan Hajnoczi
2014-03-24 13:22   ` [Qemu-trivial] " Peter Maydell
2014-03-24 13:22     ` [Qemu-devel] " Peter Maydell
2014-03-24 14:17     ` [Qemu-trivial] " Andreas Färber
2014-03-24 14:17       ` Andreas Färber
2014-03-25  9:00     ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-25  9:00       ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533BEC2E.2050802@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=alex@alex.org.uk \
    --cc=aliguori@amazon.com \
    --cc=av1474@comtv.ru \
    --cc=g.lettieri@iet.unipi.it \
    --cc=jan.kiszka@siemens.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=prasadjoshi.linux@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rizzo@iet.unipi.it \
    --cc=stefanha@redhat.com \
    --cc=v.maffione@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.