From: Jens Axboe <axboe@kernel.dk>
To: Erwan Velu <erwan@enovance.com>, fio@vger.kernel.org
Subject: Re: Surprising use of basename in finish_log_named
Date: Wed, 02 Apr 2014 07:44:20 -0600 [thread overview]
Message-ID: <533C1434.2070203@kernel.dk> (raw)
In-Reply-To: <533BC63A.1020301@enovance.com>
On 2014-04-02 02:11, Erwan Velu wrote:
>
> Le 01/04/2014 20:49, Jens Axboe a �crit :
>> I don't think there's a good reason for that. So feel free to send in
>> a (tested) patch :-)
> Please find my branch ready for master here :
> https://github.com/enovance/fio/tree/erwan/nobasename
Thanks, pulled.
>> We can make it PATH_MAX instead, not a big deal
> I've been looking at it and fixing it in iolog is pretty easy but I have
> some fear that it will not be enough to fix it globally. I mean, there
> is many occurences of paths & strings set at 256. So I'll have a look at
> a global scale for this issue in another thread.
OK, sounds good. I'm pretty sure I consistently used 256 in most places.
One problematic area might be around the server/client protocol. Maybe
it's time to finally improve that... So don't worry too much about that
part.
--
Jens Axboe
prev parent reply other threads:[~2014-04-02 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 15:00 Surprising use of basename in finish_log_named Erwan Velu
2014-04-01 18:49 ` Jens Axboe
2014-04-02 8:11 ` Erwan Velu
2014-04-02 13:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C1434.2070203@kernel.dk \
--to=axboe@kernel.dk \
--cc=erwan@enovance.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.