From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 3/4] drm/omap: fix DMM driver (un)registration Date: Wed, 2 Apr 2014 17:18:07 +0300 Message-ID: <533C1C1F.8010401@ti.com> References: <1396442280-6189-1-git-send-email-tomi.valkeinen@ti.com> <1396442280-6189-3-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1748387770==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTP id 48E3A6EB50 for ; Wed, 2 Apr 2014 07:18:14 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============1748387770== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="slKD1ieXWxa6AkXiHSAUBHgodWwaffIFt" --slKD1ieXWxa6AkXiHSAUBHgodWwaffIFt Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/04/14 17:14, Rob Clark wrote: > On Wed, Apr 2, 2014 at 8:37 AM, Tomi Valkeinen = wrote: >> At the moment the DMM driver is never unregistered, even if it's >> registered in the omapdrm module's init function. This means we'll get= >> errors when reloading the omapdrm module. >> >> Fix this by unregistering the DMM driver properly, and also change the= >> module init to fail if DMM driver cannot be registered, simplifying th= e >> unregister path as we don't need to keep the state whether we register= ed >> the DMM driver or not. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/omap_drv.c | 23 +++++++++++++++++++---- >> 1 file changed, 19 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omap= drm/omap_drv.c >> index df3e66416a30..f16a07d1668d 100644 >> --- a/drivers/gpu/drm/omapdrm/omap_drv.c >> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c >> @@ -727,18 +727,33 @@ static struct platform_driver pdev =3D { >> >> static int __init omap_drm_init(void) >> { >> + int r; >> + >> DBG("init"); >> - if (platform_driver_register(&omap_dmm_driver)) { >> - /* we can continue on without DMM.. so not fatal */ >> - dev_err(NULL, "DMM registration failed\n"); >> + >> + r =3D platform_driver_register(&omap_dmm_driver); >=20 > the one thing I wonder slightly about, this is making omap_dmm_driver > register fail fatal, whereas it wasn't before.. >=20 > That said, I don't remember in which case the dmm driver registration > would fail. I think registering the driver should succeed even (for > example) on omap3 without dmm/tiler device. But I guess you've > probably tested on o3 just to make sure? Assuming you have: Yes. I think the driver registration could fail more or less only if we're out of memory, or the driver is already register, or some other similar situation. Tomi --slKD1ieXWxa6AkXiHSAUBHgodWwaffIFt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJTPBwgAAoJEPo9qoy8lh71gEwP/jmLfpl16t95mVTLmUyIANwZ TTzzXUVSHy+Skt6KsQ7aBAjuv5gIGGfRSvjcyMrFCuv9intDO4jr6jAiUsmsY/aY Ixn8/dNd98jGYjXR2wWX5QgOrz5aAI0i9OoVQA+tkJHwLyAMIJAi8+bF7ZQ/HmxZ NSeooPa600m5DwtLqlYMlwoZaGMRf0n1zEBHEvn2cQ5AXrfxFRukX8cRzKGV/6x9 UUbtu//HBSNQ+zxroIW1PwDJPKq/Ix4k3Aek9bYbUnmGzBS5l19I+IiVgDkZ9+kr 9lCpLuDjQYWK5EjbRZDnoeVi74Xdh8Qqtbo99YLEfEuVuWTH2UapjmCrtgnYGl1d yeaxlPvF4Lu3fF4g5EzaggsAom33Pt2HlZpLegRO/oQQ8eeiIeT16lp7JkCeQcq6 vxX2yxco86tl6V3+28TPl6HB90o5H/drBGhN6+/exv28/hCdK7H/Q9Roj/kxMtTP BWJ5VWYJM0bnRhbf4FRO0GREyApojntXs/j1PYhMwBfq/8b4kdXsXWNsmC9s/4/+ LTpCPDE/LIA9lTud10s3RjndMnISjrCx1daC2hz7IYEW4p4iMFQcZ71W5QFa4YRH FN7/Zlqnmwu2y5rAlu+tftCou0jHAZbA9uG3QK80hfq2MrCH6Kli/AQxMqRS0lfX 5iDVR/fnntI2HHlgU3sq =cQK+ -----END PGP SIGNATURE----- --slKD1ieXWxa6AkXiHSAUBHgodWwaffIFt-- --===============1748387770== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1748387770==--