From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [tegrarcm PATCH 1/1] tegrarcm: Add odm production secure mode support Date: Wed, 02 Apr 2014 11:06:54 -0600 Message-ID: <533C43AE.1090502@wwwdotorg.org> References: <1396403868-14479-1-git-send-email-pchiu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1396403868-14479-1-git-send-email-pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Penny Chiu , AMartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 04/01/2014 07:57 PM, Penny Chiu wrote: > tegrarcm should work if the operating mode is ODM production > secure mode. Add the operating mode definition and description. > diff --git a/src/main.c b/src/main.c > if (info.op_mode != RCM_OP_MODE_DEVEL && > info.op_mode != RCM_OP_MODE_ODM_OPEN && > + info.op_mode != RCM_OP_MODE_ODM_SECURE && > info.op_mode != RCM_OP_MODE_PRE_PRODUCTION) Are there even more modes beyond those? I wonder if that check is even necessary any more, or whether tegrarcm should just try to communicate no matter what. Still, any changes here can be addressed in a separate patch. Acked-by: Stephen Warren Allen, will you apply this or do you want me to?