From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY
Date: Wed, 2 Apr 2014 14:17:19 -0400 [thread overview]
Message-ID: <533C542F.4020608@ti.com> (raw)
In-Reply-To: <20140402181655.GB23998@kroah.com>
On Wednesday 02 April 2014 02:16 PM, Greg KH wrote:
> On Wed, Apr 02, 2014 at 01:53:19PM -0400, Santosh Shilimkar wrote:
>> On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote:
>>>> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote:
>>>>> This fixes a regression on Keystone 2 platforms caused by patch
>>>>> 57303488cd37da58263e842de134dc65f7c626d5
>>>>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds
>>>>> optional support of generic phy in DWC3 core.
>>>>>
>>>>> On Keystone 2 platforms the USB is not working now because
>>>>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs
>>>>> return -ENOSYS always. The log shows:
>>>>> dwc3 2690000.dwc3: failed to initialize core
>>>>> dwc3: probe of 2690000.dwc3 failed with error -38
>>>>>
>>>>> Hence, fix it by making NULL a valid phy reference in Generic PHY
>>>>> APIs stubs in the same way as it was done by the patch
>>>>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL
>>>>> a valid phy reference".
>>>>>
>>>>> CC: Kishon Vijay Abraham I <kishon@ti.com>
>>>>> CC: Felipe Balbi <balbi@ti.com>
>>>>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>>
>>>> nice :-)
>>>>
>>>> Acked-by: Felipe Balbi <balbi@ti.com>
>>>
>>> Greg, if your tree isn't closed yet, could you consider this patch still
>>> for v3.15 merge window ? Grygorii found a regression on Keystone
>>> platforms which this patch fixes. Let me know if you need the original
>>> patch and myself or Kishon can send it to you.
>>>
>> Just checking whether the fix was picked up for the 3.14 merge window ?
>
> 3.14 is long released, the merge window for that was months ago.
>
Sorry for the typo. I mean for upcoming v3.15 merge window.
regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <balbi@ti.com>, Grygorii Strashko <grygorii.strashko@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY
Date: Wed, 2 Apr 2014 14:17:19 -0400 [thread overview]
Message-ID: <533C542F.4020608@ti.com> (raw)
In-Reply-To: <20140402181655.GB23998@kroah.com>
On Wednesday 02 April 2014 02:16 PM, Greg KH wrote:
> On Wed, Apr 02, 2014 at 01:53:19PM -0400, Santosh Shilimkar wrote:
>> On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote:
>>>> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote:
>>>>> This fixes a regression on Keystone 2 platforms caused by patch
>>>>> 57303488cd37da58263e842de134dc65f7c626d5
>>>>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds
>>>>> optional support of generic phy in DWC3 core.
>>>>>
>>>>> On Keystone 2 platforms the USB is not working now because
>>>>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs
>>>>> return -ENOSYS always. The log shows:
>>>>> dwc3 2690000.dwc3: failed to initialize core
>>>>> dwc3: probe of 2690000.dwc3 failed with error -38
>>>>>
>>>>> Hence, fix it by making NULL a valid phy reference in Generic PHY
>>>>> APIs stubs in the same way as it was done by the patch
>>>>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL
>>>>> a valid phy reference".
>>>>>
>>>>> CC: Kishon Vijay Abraham I <kishon@ti.com>
>>>>> CC: Felipe Balbi <balbi@ti.com>
>>>>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>>
>>>> nice :-)
>>>>
>>>> Acked-by: Felipe Balbi <balbi@ti.com>
>>>
>>> Greg, if your tree isn't closed yet, could you consider this patch still
>>> for v3.15 merge window ? Grygorii found a regression on Keystone
>>> platforms which this patch fixes. Let me know if you need the original
>>> patch and myself or Kishon can send it to you.
>>>
>> Just checking whether the fix was picked up for the 3.14 merge window ?
>
> 3.14 is long released, the merge window for that was months ago.
>
Sorry for the typo. I mean for upcoming v3.15 merge window.
regards,
Santosh
next prev parent reply other threads:[~2014-04-02 18:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 11:11 [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY Grygorii Strashko
2014-03-13 11:11 ` Grygorii Strashko
2014-03-13 13:37 ` Santosh Shilimkar
2014-03-13 13:37 ` Santosh Shilimkar
2014-03-13 13:43 ` Kishon Vijay Abraham I
2014-03-13 13:43 ` Kishon Vijay Abraham I
2014-03-13 13:47 ` Santosh Shilimkar
2014-03-13 13:47 ` Santosh Shilimkar
2014-04-16 10:09 ` Kishon Vijay Abraham I
2014-04-16 10:09 ` Kishon Vijay Abraham I
2014-03-13 15:20 ` Felipe Balbi
2014-03-13 15:20 ` Felipe Balbi
2014-03-13 21:44 ` Felipe Balbi
2014-03-13 21:44 ` Felipe Balbi
2014-04-02 17:53 ` Santosh Shilimkar
2014-04-02 17:53 ` Santosh Shilimkar
2014-04-02 18:16 ` Greg KH
2014-04-02 18:16 ` Greg KH
2014-04-02 18:17 ` Santosh Shilimkar [this message]
2014-04-02 18:17 ` Santosh Shilimkar
2014-04-02 18:26 ` Greg KH
2014-04-02 18:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C542F.4020608@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.