From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <andreas.faerber@web.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0
Date: Wed, 02 Apr 2014 11:52:34 -0700 [thread overview]
Message-ID: <533C5C72.70200@twiddle.net> (raw)
In-Reply-To: <1396447598-11205-1-git-send-email-andreas.faerber@web.de>
On 04/02/2014 07:06 AM, Andreas Färber wrote:
> FreeBSD 10.0-RELEASE has bswap16() etc. macros defined in sys/endian.h,
> which leads to a conflict with our static inline definitions.
>
> Force using the system version of the macros.
>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
> On 9.0-RELEASE I did not have this issue, so unsure if some version check
> is needed or some more generic configure check?
Looks plausible, but I have no bsd specific experience.
I'd say if it works for both 9.0 and 10.0, let it go in as is.
r~
next prev parent reply other threads:[~2014-04-02 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 14:06 [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0 Andreas Färber
2014-04-02 18:52 ` Richard Henderson [this message]
2014-04-02 20:57 ` Ed Maste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C5C72.70200@twiddle.net \
--to=rth@twiddle.net \
--cc=andreas.faerber@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.