From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices
Date: Wed, 02 Apr 2014 22:33:30 +0200 [thread overview]
Message-ID: <533C741A.6020809@kamp.de> (raw)
In-Reply-To: <1396443917-3647-1-git-send-email-pbonzini@redhat.com>
Am 02.04.2014 15:05, schrieb Paolo Bonzini:
> Non-block SCSI devices do not support flushing, but we may still send
> them requests via bdrv_flush_all. Just ignore them.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/iscsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 0d15b4d..00316af 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs)
> IscsiLun *iscsilun = bs->opaque;
> struct IscsiTask iTask;
>
> + if (bs->sg) {
> + return 0;
> + }
> +
> iscsi_co_init_iscsitask(iscsilun, &iTask);
>
> retry:
Reviewed-by: Peter Lieven <pl@kamp.de>
prev parent reply other threads:[~2014-04-02 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 13:05 [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices Paolo Bonzini
2014-04-02 20:33 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C741A.6020809@kamp.de \
--to=pl@kamp.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.