All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: Biji John <bjohn@tilera.com>, "tj@kernel.org" <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: SATA link issue with Marvell 9170
Date: Wed, 02 Apr 2014 23:10:10 -0600	[thread overview]
Message-ID: <533CED32.8060906@gmail.com> (raw)
In-Reply-To: <26AEAD365CFA784DA33319947CEB5DF86201255F@USCAEXCH1.tad.internal.tilera.com>

On 01/04/14 03:17 PM, Biji John wrote:
> Tejun,
>
> I'm running into an intermittent issue while trying to run one of our boards. It has the Marvell 9170 SATA controller connected to one of our PCIe buses. On the other side is an MSATA device. I'm running kernel 3.4.76. Intermittently, the link will not come up, it looks like the driver tries to bring the link up at 3Gbps, and then eventually fails, and the kernel will hang waiting for the root device. From doing a Google search, I noticed that this version of the ahci driver does not have the entries for 9170 (and 9178) in ahci_pci_tbl. Is this expected behavior? After adding the following patch, I'm seeing improvement, and am wondering how the patch might be helping in this regard.
>
>          { PCI_DEVICE(0x1b4b, 0x9170),
>            .driver_data = board_ahci_yes_fbs },                  /* 88se9170 */

Are you sure this is actually having a consistent effect? Relative to 
the default AHCI behavior that you'd be getting without out it, all this 
does is enable FIS-based switching, which should only make any 
difference if you had a port multiplier connected. That does result in 
the FBS enable bit being set for the port, but it seems odd that this 
would be fixing something.

  parent reply	other threads:[~2014-04-03  5:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 21:17 SATA link issue with Marvell 9170 Biji John
2014-04-02 17:16 ` tj
2014-04-03  5:10 ` Robert Hancock [this message]
2014-04-03  5:48   ` Biji John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533CED32.8060906@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=bjohn@tilera.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.