From: Sourav Poddar <sourav.poddar@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT][PATCH 5/5] spi: ti_qspi: Add delay for successful bulk erase.
Date: Thu, 3 Apr 2014 11:46:12 +0530 [thread overview]
Message-ID: <533CFCAC.7050203@ti.com> (raw)
In-Reply-To: <576167d7-5940-4423-9a97-ec63d011fb98@CH1EHSMHS020.ehs.local>
On Thursday 03 April 2014 11:30 AM, Jagan Teki wrote:
> Hi Sourav,
>
> On Wednesday 02 April 2014 04:06 PM, Sourav Poddar wrote:
>> Bulk erase is not happening properly on dra7 due to erase timing
>> constraints,
>> add a delay so that erase timing constraints are properly met.
>>
>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>> Tested-by: Yebio Mesfin <ymesfin@ti.com>
>> ---
>> drivers/spi/ti_qspi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
>> index dfa5d0c..c5d2245 100644
>> --- a/drivers/spi/ti_qspi.c
>> +++ b/drivers/spi/ti_qspi.c
>> @@ -314,6 +314,9 @@ int spi_xfer(struct spi_slave *slave, unsigned
>> int bitlen, const void *dout,
>> qslave->cmd |= QSPI_RD_SNGL;
>> debug("rx cmd %08x dc %08x\n",
>> qslave->cmd, qslave->dc);
>> + #ifdef CONFIG_DRA7XX
>> + udelay(500);
>> + #endif
>
> I myself not conveyed these delays on spi_xfer() (looks odd to me), we
> already have AM43XX delay on code, can't it be possible to manage
> through status poll?
I know, its little out of place but with status poll way, erase is
inconsistent, might be some board timing constraints.
Hence, I am force to add this delay for dra board.
> I tried the status poll way, but erase is inconsistent, might be some
> board timing constraints.
> thanks!
> --
> Jagan.
>
>
> This email and any attachments are intended for the sole use of the
> named recipient(s) and contain(s) confidential information that may be
> proprietary, privileged or copyrighted under applicable law. If you
> are not the intended recipient, do not read, copy, or forward this
> email message or any attachments. Delete this email message and any
> attachments immediately.
>
>
next prev parent reply other threads:[~2014-04-03 6:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 10:36 [U-Boot] [UBOOT][PATCH 0/5] dra7: Add partition table entry and qspi boot config Sourav Poddar
2014-04-02 10:36 ` [U-Boot] [UBOOT][PATCH 1/5] board.cfg: dra7: Add QSPI " Sourav Poddar
2014-04-02 10:36 ` [U-Boot] [UBOOT][PATCH 2/5] qspi: add support for qspi4 device Sourav Poddar
2014-04-02 10:36 ` [U-Boot] [UBOOT][PATCH 3/5] configs: dra7-evm: Add mtd parts info for qspi Sourav Poddar
2014-04-02 11:43 ` Tom Rini
2014-04-03 6:29 ` Jagan Teki
2014-04-03 6:30 ` Sourav Poddar
2014-04-02 10:36 ` [U-Boot] [UBOOT][PATCH 4/5] configs: dra7-evm: change uboot offset Sourav Poddar
2014-04-02 10:36 ` [U-Boot] [UBOOT][PATCH 5/5] spi: ti_qspi: Add delay for successful bulk erase Sourav Poddar
2014-04-03 6:00 ` Jagan Teki
2014-04-03 6:16 ` Sourav Poddar [this message]
2014-04-03 6:42 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533CFCAC.7050203@ti.com \
--to=sourav.poddar@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.