All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sherif <shehabaldin.sherif@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, silentquote@gmail.com
Subject: Re: [PATCH 7/9] driver: staging: wlan-ng: Fixed white spaces issues
Date: Thu, 03 Apr 2014 10:21:21 +0200	[thread overview]
Message-ID: <533D1A01.30304@gmail.com> (raw)
In-Reply-To: <20140403074511.GY6991@mwanda>

Yes I see the error. I have tried to build the wlan-ng driver using make 
M=drivers/staging/wlan-ng/ but it built nothing, so I went one step up 
and built make M=drivers/staging/ as a whole and it built fine, I think 
I am missing something here, how do I specify this module for the build 
to test my changes?

On 04/03/2014 09:45 AM, Dan Carpenter wrote:
> On Thu, Apr 03, 2014 at 09:13:29AM +0200, Sherif Shehab Aldin wrote:
>>   static void hfa384x_usbctlx_resptimerfn(unsigned long data)
>>   {
>> -	hfa384x_t *hw = (hfa384x_t *) data;
>> +	hfa384x_t *hw = (hfa384x_t *)
>>   	unsigned long flags;
>>
>>   	spin_lock_irqsave(&hw->ctlxq.lock, flags);
>
> This breaks the build.
>
> regards,
> dan carpenter
>

  reply	other threads:[~2014-04-03  8:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  7:13 [PATCH 7/9] driver: staging: wlan-ng: Fixed white spaces issues Sherif Shehab Aldin
2014-04-03  7:45 ` Dan Carpenter
2014-04-03  8:21   ` Sherif [this message]
2014-04-03  9:38     ` Dan Carpenter
2014-04-03  9:42       ` Sherif
2014-04-03  9:48         ` Dan Carpenter
2014-04-03 23:29           ` Sherif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533D1A01.30304@gmail.com \
    --to=shehabaldin.sherif@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=silentquote@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.