From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVdGN-0002fp-5g for qemu-devel@nongnu.org; Thu, 03 Apr 2014 04:44:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVdGF-0000A0-OR for qemu-devel@nongnu.org; Thu, 03 Apr 2014 04:44:43 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:53455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVdGF-00008w-Ie for qemu-devel@nongnu.org; Thu, 03 Apr 2014 04:44:35 -0400 Received: by mail-pa0-f50.google.com with SMTP id kq14so1507152pab.23 for ; Thu, 03 Apr 2014 01:44:33 -0700 (PDT) Message-ID: <533D1F6B.4080906@ozlabs.ru> Date: Thu, 03 Apr 2014 19:44:27 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1394075460-17400-1-git-send-email-aik@ozlabs.ru> <53189FCE.2010601@suse.de> In-Reply-To: <53189FCE.2010601@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Alexander Graf , Hong-Hua Yin On 03/07/2014 03:18 AM, Andreas Färber wrote: > Am 06.03.2014 04:11, schrieb Alexey Kardashevskiy: >> Previously libvirt required the first/default PCI bus to have name "pci". >> Since QEMU can support multiple buses now, libvirt wants "pci.0" now. >> >> This removes custom busname and lets QEMU make up default names. Ufff. Does anyone know any workaround how to tell libvirt to use these custom names? Since there is no "pci" (and there is "pci.0"), libvirt cannot put any device onto default PCI bus and I do not see any way to workaround it in XML, am I missing something here? >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> I tested this with: >> -netdev tap,id=id0,ifname=tapqemu-tap-00,script=ifup.sh,downscript=ifdown.sh \ >> -device e1000,id=id1,netdev=id0,mac=C0:41:49:4b:00:00 \ >> -device \ >> spapr-pci-host-bridge,index=5,id=aikbus \ >> -netdev tap,id=id2,ifname=tap-1,script=ifup.sh,downscript=ifdown.sh \ >> -device rtl8139,id=id3,netdev=id2,bus=aikbus.0,mac=C0:41:49:4b:00:01 \ >> -device spapr-pci-vfio-host-bridge,id=id4,index=10,iommu=4 \ >> >> This creates a default PCI, an additional emulated PCI bus (named aikbus, > > aikbus.0 for the bus according to example and info qtree, but yeah ;) > >> if I omit the name, it is pci.1 which is also fine) and VFIO bus (which is >> not in upstream yet but still), this all works fine and I cannot see any flaw. >> >> >> --- >> hw/ppc/spapr_pci.c | 23 ++--------------------- >> 1 file changed, 2 insertions(+), 21 deletions(-) > > Thanks, in absence of Alex applying to qom-next: > https://github.com/afaerber/qemu-cpu/commits/qom-next > > Andreas > -- Alexey