From mboxrd@z Thu Jan 1 00:00:00 1970 From: antoine.tenart@free-electrons.com (=?UTF-8?B?QW50b2luZSBUw6luYXJ0?=) Date: Thu, 03 Apr 2014 11:14:54 +0200 Subject: [PATCH 2/3] ARM: dts: document the berlin enable-method property In-Reply-To: <533D21AF.2070508@free-electrons.com> References: <1396512496-8030-1-git-send-email-antoine.tenart@free-electrons.com> <1396512496-8030-3-git-send-email-antoine.tenart@free-electrons.com> <20140403162202.79b63729@xhacker> <533D21AF.2070508@free-electrons.com> Message-ID: <533D268E.7070502@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/04/2014 10:54, Antoine T?nart wrote: > Jisheng, > > On 03/04/2014 10:22, Jisheng Zhang wrote: >> Hi, >> >> On Thu, 3 Apr 2014 01:08:15 -0700 >> Antoine T?nart wrote: >> >>> Signed-off-by: Antoine T?nart >>> --- >>> Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt >>> b/Documentation/devicetree/bindings/arm/cpus.txt index >>> 333f4aea3029..a9e42a2dbc99 100644 --- >>> a/Documentation/devicetree/bindings/arm/cpus.txt +++ >>> b/Documentation/devicetree/bindings/arm/cpus.txt @@ -185,6 +185,8 @@ >>> nodes >>> to be present and contain the properties described below. >>> "qcom,gcc-msm8660" >>> "qcom,kpss-acc-v1" >>> "qcom,kpss-acc-v2" >>> + "marvell,88de31-smp" - cpu-core handling for >> >> why not "marvell,berlin-smp"? > > We have SMP on the BG2 and the BG2Q currently. Future boards may not be > compatible with this method (BG3 ?), I think "marvell,berlin-smp" is too > generic. > > We could use "marvell,88de31xx-smp" as Alexandre suggested. "marvell,88de31xx-smp" is not a good choice too, since futur SoC may match the "xx" and not use this method. A better way should be to use the first SoC implementing the feature, so "marvell,88de3100". Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= Subject: Re: [PATCH 2/3] ARM: dts: document the berlin enable-method property Date: Thu, 03 Apr 2014 11:14:54 +0200 Message-ID: <533D268E.7070502@free-electrons.com> References: <1396512496-8030-1-git-send-email-antoine.tenart@free-electrons.com> <1396512496-8030-3-git-send-email-antoine.tenart@free-electrons.com> <20140403162202.79b63729@xhacker> <533D21AF.2070508@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <533D21AF.2070508-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jisheng Zhang Cc: "sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" , Jimmy Xu , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 03/04/2014 10:54, Antoine T=C3=A9nart wrote: > Jisheng, > > On 03/04/2014 10:22, Jisheng Zhang wrote: >> Hi, >> >> On Thu, 3 Apr 2014 01:08:15 -0700 >> Antoine T=C3=A9nart wrote: >> >>> Signed-off-by: Antoine T=C3=A9nart >>> --- >>> Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt >>> b/Documentation/devicetree/bindings/arm/cpus.txt index >>> 333f4aea3029..a9e42a2dbc99 100644 --- >>> a/Documentation/devicetree/bindings/arm/cpus.txt +++ >>> b/Documentation/devicetree/bindings/arm/cpus.txt @@ -185,6 +185,8 @= @ >>> nodes >>> to be present and contain the properties described below. >>> "qcom,gcc-msm8660" >>> "qcom,kpss-acc-v1" >>> "qcom,kpss-acc-v2" >>> + "marvell,88de31-smp" - cpu-core handling for >> >> why not "marvell,berlin-smp"? > > We have SMP on the BG2 and the BG2Q currently. Future boards may not = be > compatible with this method (BG3 ?), I think "marvell,berlin-smp" is = too > generic. > > We could use "marvell,88de31xx-smp" as Alexandre suggested. "marvell,88de31xx-smp" is not a good choice too, since futur SoC may=20 match the "xx" and not use this method. A better way should be to use=20 the first SoC implementing the feature, so "marvell,88de3100". Antoine --=20 Antoine T=C3=A9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbaDCJPH (ORCPT ); Thu, 3 Apr 2014 05:15:07 -0400 Received: from top.free-electrons.com ([176.31.233.9]:60257 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751655AbaDCJO4 (ORCPT ); Thu, 3 Apr 2014 05:14:56 -0400 Message-ID: <533D268E.7070502@free-electrons.com> Date: Thu, 03 Apr 2014 11:14:54 +0200 From: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jisheng Zhang CC: "sebastian.hesselbarth@gmail.com" , "alexandre.belloni@free-electrons.com" , Jimmy Xu , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] ARM: dts: document the berlin enable-method property References: <1396512496-8030-1-git-send-email-antoine.tenart@free-electrons.com> <1396512496-8030-3-git-send-email-antoine.tenart@free-electrons.com> <20140403162202.79b63729@xhacker> <533D21AF.2070508@free-electrons.com> In-Reply-To: <533D21AF.2070508@free-electrons.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2014 10:54, Antoine Ténart wrote: > Jisheng, > > On 03/04/2014 10:22, Jisheng Zhang wrote: >> Hi, >> >> On Thu, 3 Apr 2014 01:08:15 -0700 >> Antoine Ténart wrote: >> >>> Signed-off-by: Antoine Ténart >>> --- >>> Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt >>> b/Documentation/devicetree/bindings/arm/cpus.txt index >>> 333f4aea3029..a9e42a2dbc99 100644 --- >>> a/Documentation/devicetree/bindings/arm/cpus.txt +++ >>> b/Documentation/devicetree/bindings/arm/cpus.txt @@ -185,6 +185,8 @@ >>> nodes >>> to be present and contain the properties described below. >>> "qcom,gcc-msm8660" >>> "qcom,kpss-acc-v1" >>> "qcom,kpss-acc-v2" >>> + "marvell,88de31-smp" - cpu-core handling for >> >> why not "marvell,berlin-smp"? > > We have SMP on the BG2 and the BG2Q currently. Future boards may not be > compatible with this method (BG3 ?), I think "marvell,berlin-smp" is too > generic. > > We could use "marvell,88de31xx-smp" as Alexandre suggested. "marvell,88de31xx-smp" is not a good choice too, since futur SoC may match the "xx" and not use this method. A better way should be to use the first SoC implementing the feature, so "marvell,88de3100". Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com