From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-x22d.google.com (mail-pd0-x22d.google.com [IPv6:2607:f8b0:400e:c02::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CBB8B1400DF for ; Thu, 3 Apr 2014 20:57:58 +1100 (EST) Received: by mail-pd0-f173.google.com with SMTP id z10so1551164pdj.4 for ; Thu, 03 Apr 2014 02:57:55 -0700 (PDT) Message-ID: <533D30A1.1060509@gmail.com> Date: Thu, 03 Apr 2014 17:57:53 +0800 From: zhuyj MIME-Version: 1.0 To: Willy Tarreau Subject: Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic References: <53310F4E.4080104@gmail.com> <533D25D4.4000607@gmail.com> <20140403092727.GD16158@1wt.eu> In-Reply-To: <20140403092727.GD16158@1wt.eu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: "Yang, Zhangle \(Eric\)" , netdev@vger.kernel.org, richardcochran@gmail.com, linuxppc-dev@lists.ozlabs.org, guang.yang@windriver.com, linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn, sandeep.kumar@freescale.com, Claudiu Manoil , "Tao, Yue" , joe@perches.com, festevam@gmail.com, clarocq@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/03/2014 05:27 PM, Willy Tarreau wrote: > Hi Zhu, > > On Thu, Apr 03, 2014 at 05:11:48PM +0800, zhuyj wrote: >> Hi, Claudiu >> >> Please help to review this patch. This patch is for kernel 2.6.x. Thanks >> a lot. >> >> Hi, Willy >> >> Please help to merge this patch to longterm: 2.6.32.61 since this >> problem also occurs on this kernel. Thanks a lot. > Could you please send the reference to the equivalent mainline commit (the one > which disables the tx vlan feature I'm assuming) ? I'll happily queue it for > 2.6.32.62. > > Thanks, > Willy > > Hi, Willy I reference the following 2 mainline commits. These 2 commits are based on the current kernel 3.x and ethtool. If we only backport these 2 commits on kernel 2.6.x, this problem will not be fixed yet. Best Regards! Zhu Yanjun 1. commit 87c288c6e9aa31720b72e2bc2d665e24e1653c3e Author: Jiri Pirko Date: Wed Jul 20 04:54:19 2011 +0000 gianfar: do vlan cleanup - unify vlan and nonvlan rx path - kill priv->vlgrp and gfar_vlan_rx_register - allow to turn on/off rx/tx vlan accel via ethtool Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller drivers/net/gianfar.c | 55 ++++++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 26 deletions(-) 2.commit b852b720877e6b8e12b95a7cb4e00ea351b8cbfc Author: Sebastian Pöhn Date: Tue Jul 26 00:03:13 2011 +0000 gianfar: fix bug caused by 87c288c6e9aa31720b72e2bc2d665e24e1653c3e commit 87c288c6e9aa31720b72e2bc2d665e24e1653c3e "gianfar: do vlan cleanup" has two issues: # permutation of rx and tx flags # enabling vlan tag insertion by default (this leads to unusable connections on some configurations) If VLAN insertion is requested (via ethtool) it will be set at an other point ... Signed-off-by: Sebastian Poehn Signed-off-by: David S. Miller drivers/net/gianfar.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751723AbaDCJ6D (ORCPT ); Thu, 3 Apr 2014 05:58:03 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:59776 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbaDCJ54 (ORCPT ); Thu, 3 Apr 2014 05:57:56 -0400 Message-ID: <533D30A1.1060509@gmail.com> Date: Thu, 03 Apr 2014 17:57:53 +0800 From: zhuyj User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Willy Tarreau CC: sandeep.kumar@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Tao, Yue" , "Yang, Zhangle (Eric)" , guang.yang@windriver.com, joe@perches.com, festevam@gmail.com, linuxppc-dev@lists.ozlabs.org, richardcochran@gmail.com, clarocq@gmail.com, yongjun_wei@trendmicro.com.cn, Claudiu Manoil Subject: Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic References: <53310F4E.4080104@gmail.com> <533D25D4.4000607@gmail.com> <20140403092727.GD16158@1wt.eu> In-Reply-To: <20140403092727.GD16158@1wt.eu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2014 05:27 PM, Willy Tarreau wrote: > Hi Zhu, > > On Thu, Apr 03, 2014 at 05:11:48PM +0800, zhuyj wrote: >> Hi, Claudiu >> >> Please help to review this patch. This patch is for kernel 2.6.x. Thanks >> a lot. >> >> Hi, Willy >> >> Please help to merge this patch to longterm: 2.6.32.61 since this >> problem also occurs on this kernel. Thanks a lot. > Could you please send the reference to the equivalent mainline commit (the one > which disables the tx vlan feature I'm assuming) ? I'll happily queue it for > 2.6.32.62. > > Thanks, > Willy > > Hi, Willy I reference the following 2 mainline commits. These 2 commits are based on the current kernel 3.x and ethtool. If we only backport these 2 commits on kernel 2.6.x, this problem will not be fixed yet. Best Regards! Zhu Yanjun 1. commit 87c288c6e9aa31720b72e2bc2d665e24e1653c3e Author: Jiri Pirko Date: Wed Jul 20 04:54:19 2011 +0000 gianfar: do vlan cleanup - unify vlan and nonvlan rx path - kill priv->vlgrp and gfar_vlan_rx_register - allow to turn on/off rx/tx vlan accel via ethtool Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller drivers/net/gianfar.c | 55 ++++++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 26 deletions(-) 2.commit b852b720877e6b8e12b95a7cb4e00ea351b8cbfc Author: Sebastian Pöhn Date: Tue Jul 26 00:03:13 2011 +0000 gianfar: fix bug caused by 87c288c6e9aa31720b72e2bc2d665e24e1653c3e commit 87c288c6e9aa31720b72e2bc2d665e24e1653c3e "gianfar: do vlan cleanup" has two issues: # permutation of rx and tx flags # enabling vlan tag insertion by default (this leads to unusable connections on some configurations) If VLAN insertion is requested (via ethtool) it will be set at an other point ... Signed-off-by: Sebastian Poehn Signed-off-by: David S. Miller drivers/net/gianfar.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhuyj Subject: Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic Date: Thu, 03 Apr 2014 17:57:53 +0800 Message-ID: <533D30A1.1060509@gmail.com> References: <53310F4E.4080104@gmail.com> <533D25D4.4000607@gmail.com> <20140403092727.GD16158@1wt.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: "Yang, Zhangle \(Eric\)" , netdev@vger.kernel.org, richardcochran@gmail.com, linuxppc-dev@lists.ozlabs.org, guang.yang@windriver.com, linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn, sandeep.kumar@freescale.com, Claudiu Manoil , "Tao, Yue" , joe@perches.com, festevam@gmail.com, clarocq@gmail.com To: Willy Tarreau Return-path: In-Reply-To: <20140403092727.GD16158@1wt.eu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: netdev.vger.kernel.org T24gMDQvMDMvMjAxNCAwNToyNyBQTSwgV2lsbHkgVGFycmVhdSB3cm90ZToKPiBIaSBaaHUsCj4K PiBPbiBUaHUsIEFwciAwMywgMjAxNCBhdCAwNToxMTo0OFBNICswODAwLCB6aHV5aiB3cm90ZToK Pj4gSGksIENsYXVkaXUKPj4KPj4gUGxlYXNlIGhlbHAgdG8gcmV2aWV3IHRoaXMgcGF0Y2guIFRo aXMgcGF0Y2ggaXMgZm9yIGtlcm5lbCAyLjYueC4gVGhhbmtzCj4+IGEgbG90Lgo+Pgo+PiBIaSwg V2lsbHkKPj4KPj4gUGxlYXNlIGhlbHAgdG8gbWVyZ2UgdGhpcyBwYXRjaCB0byBsb25ndGVybTog Mi42LjMyLjYxIHNpbmNlIHRoaXMKPj4gcHJvYmxlbSBhbHNvIG9jY3VycyBvbiB0aGlzIGtlcm5l bC4gVGhhbmtzIGEgbG90Lgo+IENvdWxkIHlvdSBwbGVhc2Ugc2VuZCB0aGUgcmVmZXJlbmNlIHRv IHRoZSBlcXVpdmFsZW50IG1haW5saW5lIGNvbW1pdCAodGhlIG9uZQo+IHdoaWNoIGRpc2FibGVz IHRoZSB0eCB2bGFuIGZlYXR1cmUgSSdtIGFzc3VtaW5nKSA/IEknbGwgaGFwcGlseSBxdWV1ZSBp dCBmb3IKPiAyLjYuMzIuNjIuCj4KPiBUaGFua3MsCj4gV2lsbHkKPgo+CkhpLCBXaWxseQoKSSBy ZWZlcmVuY2UgdGhlIGZvbGxvd2luZyAyIG1haW5saW5lIGNvbW1pdHMuIFRoZXNlIDIgY29tbWl0 cyBhcmUgYmFzZWQgCm9uIHRoZSBjdXJyZW50IGtlcm5lbCAzLnggYW5kIGV0aHRvb2wuCklmIHdl IG9ubHkgYmFja3BvcnQgdGhlc2UgMiBjb21taXRzIG9uIGtlcm5lbCAyLjYueCwgdGhpcyBwcm9i bGVtIHdpbGwgCm5vdCBiZSBmaXhlZCB5ZXQuCgpCZXN0IFJlZ2FyZHMhClpodSBZYW5qdW4KCjEu IGNvbW1pdCA4N2MyODhjNmU5YWEzMTcyMGI3MmUyYmMyZDY2NWUyNGUxNjUzYzNlCkF1dGhvcjog SmlyaSBQaXJrbyA8anBpcmtvQHJlZGhhdC5jb20+CkRhdGU6ICAgV2VkIEp1bCAyMCAwNDo1NDox OSAyMDExICswMDAwCgogICAgIGdpYW5mYXI6IGRvIHZsYW4gY2xlYW51cAoKICAgICAtIHVuaWZ5 IHZsYW4gYW5kIG5vbnZsYW4gcnggcGF0aAogICAgIC0ga2lsbCBwcml2LT52bGdycCBhbmQgZ2Zh cl92bGFuX3J4X3JlZ2lzdGVyCiAgICAgLSBhbGxvdyB0byB0dXJuIG9uL29mZiByeC90eCB2bGFu IGFjY2VsIHZpYSBldGh0b29sCgogICAgIFNpZ25lZC1vZmYtYnk6IEppcmkgUGlya28gPGpwaXJr b0ByZWRoYXQuY29tPgogICAgIFNpZ25lZC1vZmYtYnk6IERhdmlkIFMuIE1pbGxlciA8ZGF2ZW1A ZGF2ZW1sb2Z0Lm5ldD4KCiAgZHJpdmVycy9uZXQvZ2lhbmZhci5jIHwgICA1NSAKKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIDEgZmlsZSBjaGFuZ2Vk LCAyOSBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKCjIuY29tbWl0IGI4NTJiNzIwODc3 ZTZiOGUxMmI5NWE3Y2I0ZTAwZWEzNTFiOGNiZmMKQXV0aG9yOiBTZWJhc3RpYW4gUMO2aG4gPHNl YmFzdGlhbi5iZWxkZW5AZ29vZ2xlbWFpbC5jb20+CkRhdGU6ICAgVHVlIEp1bCAyNiAwMDowMzox MyAyMDExICswMDAwCgogICAgIGdpYW5mYXI6IGZpeCBidWcgY2F1c2VkIGJ5IDg3YzI4OGM2ZTlh YTMxNzIwYjcyZTJiYzJkNjY1ZTI0ZTE2NTNjM2UKCiAgICAgY29tbWl0IDg3YzI4OGM2ZTlhYTMx NzIwYjcyZTJiYzJkNjY1ZTI0ZTE2NTNjM2UgImdpYW5mYXI6IGRvIHZsYW4gCmNsZWFudXAiIGhh cyB0d28gaXNzdWVzOgogICAgICMgcGVybXV0YXRpb24gb2YgcnggYW5kIHR4IGZsYWdzCiAgICAg IyBlbmFibGluZyB2bGFuIHRhZyBpbnNlcnRpb24gYnkgZGVmYXVsdCAodGhpcyBsZWFkcyB0byB1 bnVzYWJsZSAKY29ubmVjdGlvbnMgb24gc29tZSBjb25maWd1cmF0aW9ucykKCiAgICAgSWYgVkxB TiBpbnNlcnRpb24gaXMgcmVxdWVzdGVkICh2aWEgZXRodG9vbCkgaXQgd2lsbCBiZSBzZXQgYXQg YW4gCm90aGVyIHBvaW50IC4uLgoKICAgICBTaWduZWQtb2ZmLWJ5OiBTZWJhc3RpYW4gUG9laG4g PHNlYmFzdGlhbi5wb2VobkBiZWxkZW4uY29tPgogICAgIFNpZ25lZC1vZmYtYnk6IERhdmlkIFMu IE1pbGxlciA8ZGF2ZW1AZGF2ZW1sb2Z0Lm5ldD4KCiAgZHJpdmVycy9uZXQvZ2lhbmZhci5jIHwg ICAgNiArLS0tLS0KICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDUgZGVsZXRpb25z KC0pCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBz Oi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=