Re: [Qemu-devel] [PATCH] megasas: remove buildtime strings

[Paolo Bonzini <pbonzini@redhat.com>]

Il 03/04/2014 15:47, Olaf Hering ha scritto:
> Using __DATE__ or __TIME__ in binary pkgs changes the checksum of
> compiled binaries if they get rebuilt, even if there are no other
> source changes.  Replace the dynamic strings with some equally
> informative static strings.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>
> Or remove both lines alltogether. You decide.
>
>  hw/scsi/megasas.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index e6e1ffd..db89227 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -717,8 +717,8 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)
>      snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION);
>      memcpy(info.image_component[0].name, "APP", 3);
>      memcpy(info.image_component[0].version, MEGASAS_VERSION "-QEMU", 9);
> -    memcpy(info.image_component[0].build_date, __DATE__, 11);
> -    memcpy(info.image_component[0].build_time, __TIME__, 8);
> +    memcpy(info.image_component[0].build_date, "Apr  1 2014", 11);
> +    memcpy(info.image_component[0].build_time, "12:34:56", 8);
>      info.image_component_count = 1;
>      if (pci_dev->has_rom) {
>          uint8_t biosver[32];
>

Applied to scsi-next, thanks.

Paolo