All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Linux MMC List <linux-mmc@vger.kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	linux-kernel <linux-kernel@lists.codethink.co.uk>,
	Rob Taylor <rob.taylor@codethink.co.uk>,
	William Towle <william.towle@codethink.co.uk>
Subject: Re: [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790
Date: Thu, 03 Apr 2014 16:01:23 +0100	[thread overview]
Message-ID: <533D77C3.7000606@codethink.co.uk> (raw)
In-Reply-To: 877g9g7m3r.wl%kuninori.morimoto.gx@gmail.com

We tested this patch with our current kernel, and have a question
about the addition of the of_rcar_gen2_compatible area.

+static const struct sh_mobile_sdhi_of_data of_rcar_gen2_compatible = {
+       .tmio_flags     = TMIO_MMC_HAS_IDLE_WAIT | 
TMIO_MMC_WRPROTECT_DISABLE,
+       .capabilities   = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
+       .capabilities2  = MMC_CAP2_NO_MULTI_READ,
+};

We have been doing some speed tests and this is causing an order
of magnitude speed loss with a number of cards. We're seeing 
1.2-1.6MB/sec instead of 10+MB/sec we would expect from a Class 10
or UHS-1 card.

Is there any reason to stop using the MULTI_READ as the system seems
to work without MMC_CAP2_NO_MULTI_READ.

Also, this series does not seem to be in any of the git trees I
would expect. Does it need re-sending?

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

             reply	other threads:[~2014-04-03 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 15:01 Ben Dooks [this message]
2014-04-04  0:38 ` [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790 Kuninori Morimoto
  -- strict thread matches above, loose matches on Subject: below --
2014-01-28  4:44 mmc: sh_mobile_sdhi: DT update for R-Car Kuninori Morimoto
2014-01-31  5:30 ` Kuninori Morimoto
2014-01-31  5:32   ` [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790 Kuninori Morimoto
2014-01-31  5:32     ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533D77C3.7000606@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rob.taylor@codethink.co.uk \
    --cc=william.towle@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.