Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

On 04/03/2014 12:01 PM, Paolo Bonzini wrote:
> Il 03/04/2014 18:56, Nikunj A Dadhania ha scritto:
>> The following commit caused the regression in qemu-system-ppc64
>>
>> 7effdaa3: spapr: Fix return value of vga initialization
>> d44229c5: Fix vga_interface_type for command line argument '-device VGA'
>>
>> Even when -nodefaults was provided, USB Keyboard and Mouse was added
>> to the machine. This breaks libvirt which uses -nodefaults and adds
>> the keyboard and mouse separately. The machine got 2 USB Keyboards
>> and 2 USB Mouses.

s/Mouses/Mice/

> 
> Does libvirt use "-nodefaults -machine usb=true"?  It should create the
> OHCI controller separately instead of using "-machine".

At least with x86 emulation, libvirt prefers '-nodefaults -machine
usb=off -device piix3-usb-uhci'; so I'm assuming libvirt knows how to
directly create the USB devices it needs.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]