From: Don Slutz <dslutz@verizon.com>
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v10 01/19] xenctx: Correct FMT_??B_WORD for arm64.
Date: Thu, 03 Apr 2014 16:53:36 -0400 [thread overview]
Message-ID: <533DCA50.4050209@terremark.com> (raw)
In-Reply-To: <1396552029-21318-2-git-send-email-dslutz@verizon.com>
On 04/03/14 15:06, Don Slutz wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
>
> These should all be unsigned long long to match various variables used
> in the
> code, same as x86_64.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
I think I can add:
Reviewed-by: Don Slutz <dslutz@verizon.com>
And it I may also have forgotten to add:
Signed-off-by: Don Slutz <dslutz@verizon.com>
-Don Slutz
> ---
> tools/xentrace/xenctx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> index 7275a00..47712ab 100644
> --- a/tools/xentrace/xenctx.c
> +++ b/tools/xentrace/xenctx.c
> @@ -57,8 +57,8 @@ typedef uint64_t guest_word_t;
> #elif defined(__aarch64__)
> #define NO_TRANSLATION
> typedef uint64_t guest_word_t;
> -#define FMT_32B_WORD "%08lx"
> -#define FMT_64B_WORD "%016lx"
> +#define FMT_32B_WORD "%08llx"
> +#define FMT_64B_WORD "%016llx"
> #endif
>
> struct symbol {
next prev parent reply other threads:[~2014-04-03 20:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 19:06 [PATCH v10 00/19] xenctx: Many changes Don Slutz
2014-04-03 19:06 ` [PATCH v10 01/19] xenctx: Correct FMT_??B_WORD for arm64 Don Slutz
2014-04-03 20:53 ` Don Slutz [this message]
2014-04-04 8:46 ` Ian Campbell
2014-04-03 19:06 ` [PATCH v10 02/19] xenctx: clean up usage output Don Slutz
2014-04-03 19:06 ` [PATCH v10 03/19] xenctx: Clean up stack trace when hypercall_page not in symbol table Don Slutz
2014-04-03 19:06 ` [PATCH v10 04/19] xenctx: Add -n (--display-stack-pages) option to output larger stack Don Slutz
2014-04-03 19:06 ` [PATCH v10 05/19] xenctx: Add command line options -b (--bytes-per-line) and -l (--lines) Don Slutz
2014-04-03 19:06 ` [PATCH v10 06/19] xenctx: Add command line option -D (--decode-as-ascii) Don Slutz
2014-04-03 19:06 ` [PATCH v10 07/19] xenctx: Add command line option -t (--tag-stack-dump) Don Slutz
2014-04-03 19:06 ` [PATCH v10 08/19] xenctx: Change print_symbol to do the space before Don Slutz
2014-04-03 19:06 ` [PATCH v10 09/19] xenctx: More info on failed to map page Don Slutz
2014-04-03 19:07 ` [PATCH v10 10/19] xenctx: Add output of stack address to Call and Stack Trace Don Slutz
2014-04-03 19:07 ` [PATCH v10 11/19] xenctx: Add -m (--memory) <maddr> option to dump memory at maddr Don Slutz
2014-04-03 19:07 ` [PATCH v10 12/19] xenctx: Add error output if --all-vcpus (-C) and [VCPU] are both specified Don Slutz
2014-04-03 19:07 ` [PATCH v10 13/19] xenctx: Add -d (--dump-as-stack) <daddr> option to dump memory at daddr as a stack Don Slutz
2014-04-03 19:07 ` [PATCH v10 14/19] xenctx: change is_kernel_text() into kernel_addr() Don Slutz
2014-04-03 19:07 ` [PATCH v10 15/19] xenctx: Add conversion of more registers to symbols Don Slutz
2014-04-03 19:07 ` [PATCH v10 16/19] xenctx: Add output of vcpu value and state for --all-vcpus Don Slutz
2014-04-03 19:07 ` [PATCH v10 17/19] xenctx: Fix handling of !guest_protected_mode Don Slutz
2014-04-03 19:07 ` [PATCH v10 18/19] xenctx: Add 16 bit output Don Slutz
2014-04-03 19:07 ` [PATCH v10 19/19] xenctx: Fix print_ctx_32on64's print_special call Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533DCA50.4050209@terremark.com \
--to=dslutz@verizon.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.