Re: Coverity CID 146454: pcie_bus_configure_settings() use of uninitialized variable

[Yijing Wang <wangyijing@huawei.com>]

Hi Bjorn,
   Jon seems to send a patch to fix this long ago. Link: http://patchwork.ozlabs.org/patch/191054/
But this patch cannot be applied now. I think we can just set smpss = 0 in this function as the default value.

Thanks!
Yijing.

On 2014/4/4 0:09, Bjorn Helgaas wrote:
> Coverity complains that "smpss" is used uninitialized in
> drivers/pci/probe.c in pcie_bus_configure_settings() when calling
> pcie_bus_configure_set():
> 
> 1642        pcie_bus_configure_set(bus->self, &smpss);
> 1643        pci_walk_bus(bus, pcie_bus_configure_set, &smpss);
> 
> "smpss" may be uninitialized, and pcie_bus_configure_set()
> dereferences the pointer it receives.
> 
> This is CID 146454.
> 
> Bjorn
> 
> 


-- 
Thanks!
Yijing