From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, santosh.shilimkar@ti.com,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 2/2] net: davinci_mdio: use devm_* api
Date: Fri, 04 Apr 2014 17:18:55 +0400 [thread overview]
Message-ID: <533EB13F.5010406@cogentembedded.com> (raw)
In-Reply-To: <1396618825-4241-3-git-send-email-grygorii.strashko@ti.com>
On 04-04-2014 17:40, Grygorii Strashko wrote:
> Use devm_* API for memory allocation and to get device's clock
> to simplify driver's code.
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/net/ethernet/ti/davinci_mdio.c | 21 ++++-----------------
> 1 file changed, 4 insertions(+), 17 deletions(-)
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 0cca9de..f0f7128 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
[...]
> @@ -425,16 +417,11 @@ static int davinci_mdio_remove(struct platform_device *pdev)
>
> if (data->bus) {
> mdiobus_unregister(data->bus);
> - mdiobus_free(data->bus);
> }
Remove {} please, it's not needed anymore, according to
Documentation/CodingStyle.
WBR, Sergei
next prev parent reply other threads:[~2014-04-04 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 13:40 [PATCH 0/2] introduce devm_mdiobus_alloc/devm_mdiobus_free Grygorii Strashko
2014-04-04 13:40 ` Grygorii Strashko
2014-04-04 13:40 ` [PATCH 1/2] mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free Grygorii Strashko
2014-04-04 13:40 ` Grygorii Strashko
2014-04-04 13:15 ` Sergei Shtylyov
2014-04-08 9:52 ` Grygorii Strashko
2014-04-08 9:52 ` Grygorii Strashko
2014-04-04 13:40 ` [PATCH 2/2] net: davinci_mdio: use devm_* api Grygorii Strashko
2014-04-04 13:40 ` Grygorii Strashko
2014-04-04 13:18 ` Sergei Shtylyov [this message]
2014-04-11 4:55 ` [PATCH 0/2] introduce devm_mdiobus_alloc/devm_mdiobus_free Florian Fainelli
2014-04-11 11:05 ` Grygorii Strashko
2014-04-11 11:05 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533EB13F.5010406@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.