From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
"Andrei E. Warkentin" <andrey.warkentin@gmail.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH for-2.0 v2 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation
Date: Fri, 04 Apr 2014 07:05:38 -0700 [thread overview]
Message-ID: <533EBC32.4010404@twiddle.net> (raw)
In-Reply-To: <1396612363-13439-3-git-send-email-peter.maydell@linaro.org>
On 04/04/2014 04:52 AM, Peter Maydell wrote:
> If the guest attempts to execute from unreadable memory, this will
> cause us to longjmp back to the main loop from inside the
> target frontend decoder. For linux-user mode, this means we will
> still hold the tb_ctx.tb_lock, and will deadlock when we try to
> start executing code again. Unlock the lock in the return-from-longjmp
> code path to avoid this.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Acked-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2014-04-04 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:52 [Qemu-devel] [PATCH for-2.0 v2 0/2] fix bugs involving linux-user signal handling Peter Maydell
2014-04-04 11:52 ` [Qemu-devel] [PATCH for-2.0 v2 1/2] page_check_range: don't bail out early after unprotecting page Peter Maydell
2014-04-04 11:52 ` [Qemu-devel] [PATCH for-2.0 v2 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation Peter Maydell
2014-04-04 14:05 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533EBC32.4010404@twiddle.net \
--to=rth@twiddle.net \
--cc=andrey.warkentin@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.