From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 2/3] xen: arm: probe the kernel to determine
 the guest type earlier
Date: Fri, 04 Apr 2014 15:44:05 +0100
Message-ID: <533EC535.3040905@linaro.org>
References: <1396616194.4211.223.camel@kazak.uk.xensource.com>
	<1396616219-32219-2-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1396616219-32219-2-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 04/04/2014 01:56 PM, Ian Campbell wrote:
> +static paddr_t kernel_zimage_place(struct kernel_info *info)
> +{
> +    paddr_t load_addr;
> +
> +#ifdef CONFIG_ARM_64
> +    if ( info->type == DOMAIN_64BIT )
> +        return info->mem.bank[0].start + info->zimage.text_offset;
> +#endif
> +
> +    /*
> +     * If start is zero, the zImage is position independent, in this
> +     * case Documentation/arm/Booting recommends loading below 128MiB
> +     * and above 32MiB. Load it as high as possible within these
> +     * constraints, while also avoiding the DTB.
> +     */
> +    if (info->zimage.start == 0)

if  ( ... )

[..]

> -int kernel_prepare(struct kernel_info *info);
> +/*
> + * Probe the kernel to detemine its type and select a loader.
> + *
> + * Sets in info:
> + *  ->type
> + *  ->load hook, and sets loader specific variables ->{zimage,elf}
> + */
> +int kernel_probe(struct kernel_info *info);

I would add a newline here.

With theses 2 minor changes, the code looks good to me:

Acked-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall