From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW5fD-0002Pl-IU for qemu-devel@nongnu.org; Fri, 04 Apr 2014 11:04:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW5f9-0003AJ-6j for qemu-devel@nongnu.org; Fri, 04 Apr 2014 11:04:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW5f8-0003A4-Tm for qemu-devel@nongnu.org; Fri, 04 Apr 2014 11:04:11 -0400 Message-ID: <533EC9E1.1090109@redhat.com> Date: Fri, 04 Apr 2014 09:04:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396428990-2516-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1396428990-2516-1-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l6U3IBBqsr8RjiNS73O0QtjDlV8h3xMvW" Subject: Re: [Qemu-devel] [PATCH] xbzrle: page may not be update if it has been in the cache List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l6U3IBBqsr8RjiNS73O0QtjDlV8h3xMvW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/02/2014 02:56 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > The cache_insert don't check whether the page has been in the cache. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > page_cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/page_cache.c b/page_cache.c > index c78157b..78f7590 100644 > --- a/page_cache.c > +++ b/page_cache.c > @@ -171,7 +171,7 @@ int cache_insert(PageCache *cache, uint64_t addr, c= onst uint8_t *pdata, > /* actual update of entry */ > it =3D cache_get_by_addr(cache, addr); > =20 > - if (it->it_data && > + if (it->it_data && it->it_addr !=3D addr && > it->it_age + CACHED_PAGE_LIFETIME > current_age) { > /* the cache page is fresh, don't replace it */ > return -1; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --l6U3IBBqsr8RjiNS73O0QtjDlV8h3xMvW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTPsnhAAoJEKeha0olJ0NqgZcH/1MqIZh6b8LlXN3+4IefjyWA yll2UaQvwn9vHBYgScbCkak1snI8HpZzs02ng75TGPFRv9MYINdlFSE3l3HVxIAD SOuOlJqI+9GXCXML43llj+1DNjn/3bLqvJHLMc3sj9In5ooV/+m1ZV4HM2OVxA+H yi4a/aXIlHCJkZ1ryNRybHWwohvggfVKGIO7rrIUChS1sQhhkZd3B/lArZSRgQ9Z evx9xmohYB6tB2PygT/O+phIRddlGb7265MWNU7sDrgZZQ9ih6Kb15ZbzuNGCx55 jaz3RIvIg8eqFtxAmfxe2xh6K8HUPVXhi3lsos/p4FfeYX61JmFUiT5SKqW5JE8= =nXld -----END PGP SIGNATURE----- --l6U3IBBqsr8RjiNS73O0QtjDlV8h3xMvW--