From: Robert Yang <liezhi.yang@windriver.com>
To: Koen Kooi <koen.kooi@linaro.org>,
Paul Eggleton <paul.eggleton@linux.intel.com>,
"Purdie, Richard" <richard.purdie@intel.com>
Cc: Koen Kooi <koen@dominion.thruhere.net>,
openembedded-core@lists.openembedded.org
Subject: Re: [Dora][PATCH] buildhistory-diff: add ability to report version changes
Date: Fri, 4 Apr 2014 23:13:27 +0800 [thread overview]
Message-ID: <533ECC17.8090502@windriver.com> (raw)
In-Reply-To: <533E91BD.8000107@linaro.org>
On 04/04/2014 07:04 PM, Koen Kooi wrote:
> On 04/04/2014 01:00 PM, Paul Eggleton wrote:
>> On Friday 04 April 2014 11:15:04 Koen Kooi wrote:
>>> From: Paul Eggleton <paul.eggleton@linux.intel.com>
>>>
>>> Add a -v/--report-ver option to report changes in PKGE/PKGV/PKGR even
>>> if the value is the same as the default from PE/PV/PR.
>>>
>>> Also add a -a/--report-all option to report all changes instead of just
>>> the default significant ones.
>>
>> Hmm, looking at this I'm not sure that this is the right fix for a stable
>> branch - ideally we should just fix the error rather than backporting the
>> feature IMO.
>
> I'm fine with either, this was the easiest for me, a single cherrypick.
>
I'm very sorry to say that we need to revert the following commit from
dora, we don't need it on dora, it's my fault, I need to be more careful
when backport the patches:
commit 5b616aa7b618f6ed221d6fa9738220a2c2349f7d
Author: Paul Eggleton <paul.eggleton@linux.intel.com>
Date: Sun Nov 17 12:28:19 2013 +0000
buildhistory_analysis: fix error when comparing image contents
RP, would you please help to revert it from dora ?
// Robert
next prev parent reply other threads:[~2014-04-04 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 9:15 [Dora][PATCH] buildhistory-diff: add ability to report version changes Koen Kooi
2014-04-04 10:51 ` Robert Yang
2014-04-04 11:00 ` Paul Eggleton
2014-04-04 11:04 ` Koen Kooi
2014-04-04 15:13 ` Robert Yang [this message]
2014-04-04 15:16 ` Paul Eggleton
2014-04-04 15:17 ` Richard Purdie
2014-04-04 15:19 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533ECC17.8090502@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=koen.kooi@linaro.org \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
--cc=richard.purdie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.