From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2] tools: implement initial ramdisk support
	for ARM.
Date: Fri, 04 Apr 2014 16:16:19 +0100
Message-ID: <533ECCC3.1010404@linaro.org>
References: <1396618125-1623-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1396618125-1623-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 04/04/2014 02:28 PM, Ian Campbell wrote:
>      struct xc_dom_seg kernel_seg;
> +    /* If ramdisk_seg.vstart is non zero then the ramdisk will be
> +     * loaded at that address, otherwise it will automatically placed.
> +     *
> +     * If automatic placement is used and the ramdisk is gzip
> +     * compressed then it will be decompressed as it is loaded. If the
> +     * ramdisk has been explicitly placed then it is loaded as is
> +     * itherwise decompressing risks undoing the manual placement.

otherwise?

[..]

> @@ -326,7 +364,6 @@ int xc_dom_feature_translated(struct xc_dom_image *dom)
>   * mode: C
>   * c-file-style: "BSD"
>   * c-basic-offset: 4
> - * tab-width: 4

Does it mean that nearly every emacs magic are wrong on the other files?

[..]

> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 36e70b5..c3fa439 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -407,8 +407,8 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
>          LOGE(ERROR, "xc_dom_parse_image failed");
>          goto out;
>      }
> -    if ( (ret = libxl__arch_domain_configure(gc, info, dom)) != 0 ) {
> -        LOGE(ERROR, "libxl__arch_domain_configure failed");
> +    if ( (ret = libxl__arch_domain_init_hw_description(gc, info, dom)) != 0 ) {

Should not it be ((..))? It seems the function is using 2 different
coding style.

-- 
Julien Grall