Re: [PATCH v2] tools: implement initial ramdisk support for ARM.

[Julien Grall <julien.grall@linaro.org>]

On 04/04/2014 04:20 PM, Ian Campbell wrote:
> On Fri, 2014-04-04 at 16:16 +0100, Julien Grall wrote:
>>> @@ -326,7 +364,6 @@ int xc_dom_feature_translated(struct xc_dom_image *dom)
>>>   * mode: C
>>>   * c-file-style: "BSD"
>>>   * c-basic-offset: 4
>>> - * tab-width: 4
>>
>> Does it mean that nearly every emacs magic are wrong on the other files?
> 
> I thought there weren't many others, but looking again I'm wrong. I
> think I may have been thinking of "indent-tabs-mode: nil".
> 
> I think my emacs must have been playing up when I first edited this file
> and I confused myself into thinking this change had fixed it.
> 
>>> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
>>> index 36e70b5..c3fa439 100644
>>> --- a/tools/libxl/libxl_dom.c
>>> +++ b/tools/libxl/libxl_dom.c
>>> @@ -407,8 +407,8 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
>>>          LOGE(ERROR, "xc_dom_parse_image failed");
>>>          goto out;
>>>      }
>>> -    if ( (ret = libxl__arch_domain_configure(gc, info, dom)) != 0 ) {
>>> -        LOGE(ERROR, "libxl__arch_domain_configure failed");
>>> +    if ( (ret = libxl__arch_domain_init_hw_description(gc, info, dom)) != 0 ) {
>>
>> Should not it be ((..))? It seems the function is using 2 different
>> coding style.
> 
> Looks like some Xen list braces have slipped in here. Probably best for
> this new addition to be consistent with the surroundings though.

Ok. I forgot to give my ack on this patch (with the emacs fix)

Acked-by: Julien Grall <julien.grall@linaro.org>

-- 
Julien Grall