From mboxrd@z Thu Jan 1 00:00:00 1970 From: Murali Karicheri Date: Fri, 4 Apr 2014 13:20:03 -0400 Subject: [U-Boot] [PATCH v5 3/9] arm: add support for arch timer In-Reply-To: <4f0a897f.12abf.1452c39bd10.Coremail.fenghua@phytium.com.cn> References: <1396377869-15724-1-git-send-email-m-karicheri2@ti.com> <1396377869-15724-4-git-send-email-m-karicheri2@ti.com> <20140403104611.5E3D.AA925319@jp.panasonic.com> <4f0a897f.12abf.1452c39bd10.Coremail.fenghua@phytium.com.cn> Message-ID: <533EE9C3.4020606@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/4/2014 6:12 AM, FengHua wrote: > > >> -----Original Messages----- >> From: "Andrianov, Vitaly" >> Sent Time: 2014-04-03 19:22:34 (Thursday) >> To: "Masahiro Yamada" , "Karicheri, Muralidharan" >> Cc: "Rini, Tom" , "u-boot at lists.denx.de" >> Subject: Re: [U-Boot] [PATCH v5 3/9] arm: add support for arch timer >> >> Hi Masahiro, >> >>> -----Original Message----- >>> From: u-boot-bounces at lists.denx.de [mailto:u-boot- >>> bounces at lists.denx.de] On Behalf Of Masahiro Yamada >>> Sent: Wednesday, April 02, 2014 9:46 PM >>> To: Karicheri, Muralidharan >>> Cc: Rini, Tom; u-boot at lists.denx.de >>> Subject: Re: [U-Boot] [PATCH v5 3/9] arm: add support for arch timer >>> >>> Hi Murali, >>> >>> On Tue, 1 Apr 2014 14:44:23 -0400 >>> Murali Karicheri wrote: >>> >>>> From: Vitaly Andrianov >>>> >>>> This patch add basic support for the architecture timer found on >>>> recent >>>> ARMv7 based SoCs. >>>> >>>> Signed-off-by: Vitaly Andrianov >>>> Signed-off-by: Murali Karicheri >>>> Acked-by: Tom Rini >>>> --- >>>> arch/arm/lib/Makefile | 1 + >>>> arch/arm/lib/arch_timer.c | 58 >>> +++++++++++++++++++++++++++++++++++++++++++++ >>> >>> >>> >>> I am not familiar with this timer, but your commit description implies >>> it is specific to ARMv7. >>> >>> If so, it looks like it should go to arch/arm/cpu/armv7/ . >>> Is this right? >> This is for arch timer implemented in ARM Cortex-A15 which is ARMv7. >> I believe the same arch timer is in ARMv8. So, it is not specific to >> ARMv7 only. The commit description mentioned only ARMv7 because the >> driver was designed and tested on ARMv7. >> > If we want to apply the arch_timer.c to armv8, the get_ticks() function should be modified > due to mrrc instuction. > Furthermore, armv8 now make use of timer infrastructure of lib/time.c. > Only get_tbclk() and timer_read_counter() are architecture specific and declared in generic_timer.c. > We'd better construct a common arch timer structure across arm platform. > > Best regards, > David > > > > > The v6 of the series just posted has moved the arch_timer.c to arch/arm/cpu/armv7 folder as requested by you. Regards, Murali