All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Yi Zhang <yi.zhang@redhat.com>
Subject: blktest failures
Date: Fri, 8 Apr 2022 17:10:16 -0500	[thread overview]
Message-ID: <533dc3b0-e58a-0bc8-2f07-5dbfb3d1235e@gmail.com> (raw)

Bart,

I finally was able to build a kernel with lockdep enabled correctly and saw the error that you and others reported.
I am not familiar with lockdep output but I am guessing that it is reporting a mismatch between a _bh spinlock
and a _irqsave spinlock (since those are the only two types used by the driver.)

I went on campaign a while back to replace all the locks with _bh locks because I figured they would be
faster than _irqsave locks and because the driver never touched a lock except from a verbs API call or from
a tasklet (softirq.) As it turned out some code makes verbs API calls while in hardirq context which broke
that assumption. So some of the locks were reverted back to irqsave locks which fixed those warnings.

Now it is happening again. I did an experiment and went through the rxe driver and replaced all spinlocks
with _irqsave locks. Now the lockdep splats have gone away and the srp/001 test reports success. BUT,
it hangs and doesn't finish. If I try to run all the tests I get warnings about unable to remove the
scsi_debug driver. I am able to remove the rdma_rxe driver and reload it. I am not seeing any errors in
the rxe driver.

Do you have any ideas what to look at next?

Bob

             reply	other threads:[~2022-04-08 22:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 22:10 Bob Pearson [this message]
2022-04-08 22:50 ` blktest failures Bob Pearson
2022-04-08 23:25   ` Bart Van Assche
2022-04-09  0:31     ` Yi Zhang
2022-04-09  4:33       ` Bart Van Assche
2022-04-09  5:04     ` Christoph Hellwig
2022-04-09 21:43       ` Bob Pearson
2022-04-09 21:47         ` Bart Van Assche
2022-04-15  7:12         ` Yanjun Zhu
2022-04-15  7:26           ` Bob Pearson
2022-04-15  7:29           ` Bob Pearson
2022-04-15  7:37             ` Yanjun Zhu
2022-04-15  7:46               ` Bob Pearson
2022-04-15  7:59                 ` Yanjun Zhu
2022-04-15 15:44                   ` Bob Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533dc3b0-e58a-0bc8-2f07-5dbfb3d1235e@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.