From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [patch 10/10] can: c_can : Disable rx split as workaround Date: Sat, 05 Apr 2014 21:42:02 +0200 Message-ID: <53405C8A.3030702@grandegger.com> References: <20140404134816.751883017@linutronix.de> <20140404134858.173427806@linutronix.de> <533EDB36.6060404@del-llc.com> <53405BCC.7060701@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ngcobalt02.manitu.net ([217.11.48.102]:34739 "EHLO ngcobalt02.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753477AbaDETmF (ORCPT ); Sat, 5 Apr 2014 15:42:05 -0400 In-Reply-To: <53405BCC.7060701@grandegger.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Thomas Gleixner , Mark Cc: linux-can , Marc Kleine-Budde , Alexander Stein On 04/05/2014 09:38 PM, Wolfgang Grandegger wrote: > On 04/05/2014 08:56 PM, Thomas Gleixner wrote: >> On Fri, 4 Apr 2014, Mark wrote: >> >>> Thomas: a few comments on my experience with the CAN driver: >>> >>> I think I agree with your approach -- I had the same problem losing a packet >>> when running through the clearing of the newdat flags. >>> >>> About a month ago, I re-wrote pch_can.c (before I discovered this mailing >>> list) and got it to work successfully sending / receiving CAN data at 1 MBIT >> >> Wow, that's amazing. > > We realized late that the pch_can manual [1] is an exact copy of the > c_can manual just with different register names (and without mentioning > c_can at all). Also the initial author didn't mentioning it. Maybe he > did not even know. > >> That driver is just a variant of c_can.c with quite some of the same >> bugs and some different ones. > > It's worse :(. > >> We really should switch that over to c_can.c and get rid of it. > > See http://news.gmane.org/gmane.linux.can. Should we remove pch_can > immediately? Or labeling it deprecated first. I mean the link http://article.gmane.org/gmane.linux.can/5440 Wolfgang