All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3 6/6] Move common functions in eal_memory.c
Date: Mon, 05 Jan 2015 13:17:23 -0800 (PST)	[thread overview]
Message-ID: <5340807.22YuSvaAXs@xps13> (raw)
In-Reply-To: <1419957440-11767-6-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

2014-12-30 11:37, Ravi Kerur:
> Use common function names rte_eal_hugepage_init and
> rte_eal_hugepage_attach for BSD and Linux.

I'd like to be sure that using hugepage wording instead of contigmem
is not too weird for BSD people.
Do not forget that we have a kernel module called contigmem.
Here, an ifdef or a wrapper seems appropriate to keep right wording.

-- 
Thomas

  parent reply	other threads:[~2015-01-05 21:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30 16:36 [PATCH v3 0/6] Move EAL common functions Ravi Kerur
     [not found] ` <1419957384-11693-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-30 16:37   ` [PATCH v3 1/6] Move common functions in eal_debug.c Ravi Kerur
     [not found]     ` <1419957440-11767-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-30 16:37       ` [PATCH v3 2/6] Move common functions in eal_thread.c Ravi Kerur
2014-12-30 16:37       ` [PATCH v3 3/6] Move common functions in eal.c Ravi Kerur
2014-12-30 16:37       ` [PATCH v3 4/6] Move common functions in eal_lcore.c Ravi Kerur
2014-12-30 16:37       ` [PATCH v3 5/6] Move common functions in eal_timer.c Ravi Kerur
     [not found]         ` <1419957440-11767-5-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 21:09           ` Thomas Monjalon
2014-12-30 16:37       ` [PATCH v3 6/6] Move common functions in eal_memory.c Ravi Kerur
     [not found]         ` <1419957440-11767-6-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 21:17           ` Thomas Monjalon [this message]
2015-01-06 17:32             ` Ravi Kerur
2014-12-30 21:03   ` [PATCH v3 0/6] Move EAL common functions Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5340807.22YuSvaAXs@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.