* [Qemu-trivial] [PATCH] net: Report error when device / hub combo is not found.
@ 2014-03-31 23:05 ` Hani Benhabiles
0 siblings, 0 replies; 4+ messages in thread
From: Hani Benhabiles @ 2014-03-31 23:05 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, stefanha, aliguori
Also convert nearby monitor_printf() call to error_report().
Signed-off-by: Hani Benhabiles <hani@linux.com>
---
net/net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index e3ef1e4..d319f49 100644
--- a/net/net.c
+++ b/net/net.c
@@ -952,10 +952,12 @@ void net_host_device_remove(Monitor *mon, const QDict *qdict)
nc = net_hub_find_client_by_name(vlan_id, device);
if (!nc) {
+ error_report("Host network device '%s' on hub '%d' not found",
+ device, vlan_id);
return;
}
if (!net_host_check_device(nc->model)) {
- monitor_printf(mon, "invalid host network device %s\n", device);
+ error_report("invalid host network device '%s'", device);
return;
}
qemu_del_net_client(nc);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] net: Report error when device / hub combo is not found.
@ 2014-03-31 23:05 ` Hani Benhabiles
0 siblings, 0 replies; 4+ messages in thread
From: Hani Benhabiles @ 2014-03-31 23:05 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, stefanha, aliguori
Also convert nearby monitor_printf() call to error_report().
Signed-off-by: Hani Benhabiles <hani@linux.com>
---
net/net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index e3ef1e4..d319f49 100644
--- a/net/net.c
+++ b/net/net.c
@@ -952,10 +952,12 @@ void net_host_device_remove(Monitor *mon, const QDict *qdict)
nc = net_hub_find_client_by_name(vlan_id, device);
if (!nc) {
+ error_report("Host network device '%s' on hub '%d' not found",
+ device, vlan_id);
return;
}
if (!net_host_check_device(nc->model)) {
- monitor_printf(mon, "invalid host network device %s\n", device);
+ error_report("invalid host network device '%s'", device);
return;
}
qemu_del_net_client(nc);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] net: Report error when device / hub combo is not found.
2014-03-31 23:05 ` [Qemu-devel] " Hani Benhabiles
@ 2014-04-06 6:38 ` Michael Tokarev
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-04-06 6:38 UTC (permalink / raw)
To: Hani Benhabiles; +Cc: qemu-trivial, qemu-devel, stefanha, aliguori
01.04.2014 03:05, Hani Benhabiles wrote:
> Also convert nearby monitor_printf() call to error_report().
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-06 6:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 23:05 [Qemu-trivial] [PATCH] net: Report error when device / hub combo is not found Hani Benhabiles
2014-03-31 23:05 ` [Qemu-devel] " Hani Benhabiles
2014-04-06 6:38 ` [Qemu-trivial] " Michael Tokarev
2014-04-06 6:38 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.