All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hartmut Knaack <knaack.h@gmx.de>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: sr@denx.de
Subject: Re: [PATCH 2/6] staging:iio:adc:spear_adc drop initialization of unused scan_type
Date: Sun, 06 Apr 2014 12:11:02 +0200	[thread overview]
Message-ID: <53412836.1010802@gmx.de> (raw)
In-Reply-To: <1396716315-2465-3-git-send-email-jic23@kernel.org>

Jonathan Cameron schrieb:
> As the driver does not support the buffered interfaces of IIO this is
> not used.
I trust you in this one, but I can't assess it right now with my limited IIO-buffer background knowledge. So, regard it as a silent ack, to not hold you back.
>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> Acked-by: Stefan Roese <sr@denx.de>
> ---
>  drivers/staging/iio/adc/spear_adc.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/spear_adc.c b/drivers/staging/iio/adc/spear_adc.c
> index 49293f9..c4e928b 100644
> --- a/drivers/staging/iio/adc/spear_adc.c
> +++ b/drivers/staging/iio/adc/spear_adc.c
> @@ -179,10 +179,6 @@ static int spear_read_raw(struct iio_dev *indio_dev,
>  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),	\
>  	.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE),	\
>  	.channel = idx,					\
> -	.scan_type = {					\
> -		.sign = 'u',				\
> -		.storagebits = 16,			\
> -	},						\
>  }
>  
>  static const struct iio_chan_spec spear_adc_iio_channels[] = {


  reply	other threads:[~2014-04-06 10:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-05 16:45 [PATCH V3 0/6] iio: Minor cleanups to spear ADC driver Jonathan Cameron
2014-04-05 16:45 ` [PATCH 1/6] staging:iio:adc:spear adc - prefix defines to avoid namespace clashes Jonathan Cameron
2014-04-06 10:10   ` Hartmut Knaack
2014-04-07 17:56     ` Jonathan Cameron
2014-04-05 16:45 ` [PATCH 2/6] staging:iio:adc:spear_adc drop initialization of unused scan_type Jonathan Cameron
2014-04-06 10:11   ` Hartmut Knaack [this message]
2014-04-07 18:06     ` Jonathan Cameron
2014-04-05 16:45 ` [PATCH 3/6] staging:iio:adc:spear_adc use info_mask_shared_by_all for samp freq Jonathan Cameron
2014-04-06 10:11   ` Hartmut Knaack
2014-04-07 18:06     ` Jonathan Cameron
2014-04-05 16:45 ` [PATCH 4/6] staging:iio:adc:spear rename device specific state structure to _state Jonathan Cameron
2014-04-06 10:11   ` Hartmut Knaack
2014-04-07 18:07     ` Jonathan Cameron
2014-04-05 16:45 ` [PATCH 5/6] staging:iio:adc:spear rename iodev -> indio_dev to fit with current convention Jonathan Cameron
2014-04-06 10:11   ` Hartmut Knaack
2014-04-05 16:45 ` [PATCH 6/6] staging:iio:adc:spear rename spear_read_raw to spear_adc_read_raw Jonathan Cameron
2014-04-06 10:11   ` Hartmut Knaack
2014-04-07 18:11     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53412836.1010802@gmx.de \
    --to=knaack.h@gmx.de \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.