From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WWnrM-000809-CR for mharc-qemu-trivial@gnu.org; Sun, 06 Apr 2014 10:15:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWnrF-0007Zj-Ew for qemu-trivial@nongnu.org; Sun, 06 Apr 2014 10:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWnr8-0004lX-QL for qemu-trivial@nongnu.org; Sun, 06 Apr 2014 10:15:37 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:35566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWnqw-0004af-6T; Sun, 06 Apr 2014 10:15:18 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 95F7A40B7D; Sun, 6 Apr 2014 18:15:17 +0400 (MSK) Message-ID: <53416175.9080103@msgid.tls.msk.ru> Date: Sun, 06 Apr 2014 18:15:17 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Peter Maydell References: <1396019577-2013-1-git-send-email-peter.maydell@linaro.org> <1396019577-2013-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1396019577-2013-4-git-send-email-peter.maydell@linaro.org> X-Enigmail-Version: 1.5.1 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Subject: Re: [Qemu-trivial] [PATCH 3/3] xbzrle.c: Avoid undefined behaviour with signed arithmetic X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2014 14:15:43 -0000 28.03.2014 19:12, Peter Maydell wrote: > Use unsigned types for doing bitwise arithmetic in the xzbrle > calculations, to avoid undefined behaviour: > > xbzrle.c:99:49: runtime error: left shift of 72340172838076673 > by 7 places cannot be represented in type 'long' Aplied to -trivial, thanks! /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWnr2-0006lH-HE for qemu-devel@nongnu.org; Sun, 06 Apr 2014 10:15:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWnqw-0004aj-DX for qemu-devel@nongnu.org; Sun, 06 Apr 2014 10:15:24 -0400 Message-ID: <53416175.9080103@msgid.tls.msk.ru> Date: Sun, 06 Apr 2014 18:15:17 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1396019577-2013-1-git-send-email-peter.maydell@linaro.org> <1396019577-2013-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1396019577-2013-4-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/3] xbzrle.c: Avoid undefined behaviour with signed arithmetic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org 28.03.2014 19:12, Peter Maydell wrote: > Use unsigned types for doing bitwise arithmetic in the xzbrle > calculations, to avoid undefined behaviour: > > xbzrle.c:99:49: runtime error: left shift of 72340172838076673 > by 7 places cannot be represented in type 'long' Aplied to -trivial, thanks! /mjt