From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 0/2] app/testpmd: fix invalid rxq and txq nubmer settings Date: Wed, 17 Jan 2018 15:06:07 +0100 Message-ID: <5342816.T2QiQ58HNc@xps> References: <1515744603-60457-1-git-send-email-wei.dai@intel.com> <1515756682-69016-1-git-send-email-wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, yuan.peng@intel.com, konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, stable@dpdk.org To: Wei Dai Return-path: In-Reply-To: <1515756682-69016-1-git-send-email-wei.dai@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/01/2018 12:31, Wei Dai: > If an invlaid number of RX or TX queues is configured from testpmd > command like "port config all rxq number" or "port config all txq > number" or from --rxq and --txq in the command to start testpmd. > The global variable nb_rxq or nb_txq is updated by the invalid > input. This can cause testpmd crash. For example, if the maximum > number of RX or TX queues is 4, testpmd will crash after running > commands "port config all rxq 5", "port config all txq 5" and > "start" in sequence. > With these 2 patches, if an invalid input is detected, it is refused > and testpmd keeps last correct values of nb_rxq and nb_txq. > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai > Aced-by: Konstantin Ananyev > Tested-by: Yuan Peng Applied, thanks