From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thellstrom@vmware.com>
Subject: Re: [RFC 0/3] TTM priority queue logic
Date: Mon, 07 Apr 2014 14:25:28 +0200
Message-ID: <53429938.3050203@vmware.com>
References: <20140404165224.a4856af5.cand@gmx.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com
 [208.91.2.12])
 by gabe.freedesktop.org (Postfix) with ESMTP id EB16B6E603
 for <dri-devel@lists.freedesktop.org>; Mon,  7 Apr 2014 05:25:31 -0700 (PDT)
In-Reply-To: <20140404165224.a4856af5.cand@gmx.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Lauri Kasanen <cand@gmx.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi, Lauri.

On 04/04/2014 03:52 PM, Lauri Kasanen wrote:
> Hi list, Thomas,
>
> I'd like to know if this is going in the right direction.

This looks fine with me.

However, if possible I'd like the drivers to enable both alloc_threshold
and priority queue on a per-memory-type basis.

That would mean no new arguments (use_pqueue, alloc_threshold) in
ttm_bo_device_init(). Instead, set default values in
ttm_bo_init_mm(), and let the driver change them in the init_mem_type()
callback.

Do you think that would work?

/Thomas