From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 08/16] xen/arm: IRQ Introduce irq_get_domain Date: Mon, 07 Apr 2014 14:44:11 +0100 Message-ID: <5342ABAB.4050402@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> <1396557727-19102-9-git-send-email-julien.grall@linaro.org> <1396876530.22845.83.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WX9qQ-0004SB-EV for xen-devel@lists.xenproject.org; Mon, 07 Apr 2014 13:44:14 +0000 Received: by mail-ee0-f43.google.com with SMTP id e53so664222eek.2 for ; Mon, 07 Apr 2014 06:44:12 -0700 (PDT) In-Reply-To: <1396876530.22845.83.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/07/2014 02:15 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 21:41 +0100, Julien Grall wrote: >> This function retrieves a domain from an IRQ. It will be used in several >> places (such as do_IRQ) to avoid duplicated code when multiple action will be >> supported. >> >> Signed-off-by: Julien Grall > > Acked-by: Ian Campbell > >> --- >> Changes in v2: >> - Patch added >> --- >> xen/arch/arm/irq.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c >> index f3a30bd..5111b90 100644 >> --- a/xen/arch/arm/irq.c >> +++ b/xen/arch/arm/irq.c >> @@ -98,6 +98,15 @@ void __cpuinit init_secondary_IRQ(void) >> BUG_ON(init_local_irq_data() < 0); >> } >> >> +static inline struct domain *irq_get_domain(struct irq_desc *desc) >> +{ >> + ASSERT(spin_is_locked(&desc->lock)); >> + ASSERT(desc->status & IRQ_GUEST); > > I don't know if this will be helpful for any of the forthcoming callers > but you could return DOMID_XEN if this isn't the case. This function was created to retrieve easily the domain (mainly when we will switch to a list for the action). As it's only used withing the file and it should only be called when desc->status == IRQ_GUEST, I don't think we need to return DOMID_XEN. Regards, -- Julien Grall