All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hector Palacios <hector.palacios@digi.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs: fat: Fix cache align error message in fatwrite to use USB media
Date: Mon, 7 Apr 2014 16:19:00 +0200	[thread overview]
Message-ID: <5342B3D4.70603@digi.com> (raw)
In-Reply-To: <1396500259-6374-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hello,

On 04/03/2014 06:44 AM, Nobuhiro Iwamatsu wrote:
> Use of malloc of do_fat_write() from USB media causes cache error on

I would remove 'from USB media' from the commit log as it doesn't really matter where 
you read from.

> ARM v7 platforms. Perhaps, the same problem will occur at any other CPUs.
> This replaces malloc with memalign to fix cache buffer alignment.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Yoshiyuki Ito <yoshiyuki.ito.ub@renesas.com>
> ---
>   fs/fat/fat_write.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
> index 9f5e911..cef138e 100644
> --- a/fs/fat/fat_write.c
> +++ b/fs/fat/fat_write.c
> @@ -952,7 +952,7 @@ static int do_fat_write(const char *filename, void *buffer,
>   	}
>
>   	mydata->fatbufnum = -1;
> -	mydata->fatbuf = malloc(FATBUFSIZE);
> +	mydata->fatbuf = memalign(ARCH_DMA_MINALIGN, FATBUFSIZE);
>   	if (mydata->fatbuf == NULL) {
>   		debug("Error: allocating memory\n");
>   		return -1;
>

Tested on an i.MX6 custom platform.

Tested-by: Hector Palacios <hector.palacios@digi.com>

Thanks,
-- 
H?ctor Palacios

  reply	other threads:[~2014-04-07 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  4:44 [U-Boot] [PATCH] fs: fat: Fix cache align error message in fatwrite to use USB media Nobuhiro Iwamatsu
2014-04-07 14:19 ` Hector Palacios [this message]
2014-04-08  2:02   ` Nobuhiro Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5342B3D4.70603@digi.com \
    --to=hector.palacios@digi.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.