From: Heiner Kallweit <heiner.kallweit@web.de>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] ipv6: Reparent temporary address(es) if global address was, deleted from userspace
Date: Mon, 07 Apr 2014 20:50:32 +0200 [thread overview]
Message-ID: <5342F378.5030400@web.de> (raw)
In-Reply-To: <20140407102229.GB27255@order.stressinduktion.org>
Am 07.04.2014 12:22, schrieb Hannes Frederic Sowa:
> On Mon, Apr 07, 2014 at 07:43:12AM +0200, Heiner Kallweit wrote:
>> If the kernel takes care of global and temporary addresses it can happen
>> that the global address is deleted from userspace,
>> e.g. by network managers in case the link goes (temporarily) down.
>> In addition to the then orphaned temporary address(es) the next RA will
>> create a new temporary address. Therefore we might end up with more than
>> one non-deprecated temporary address for the same prefix for a longer
>> period of time (>regen_advance). According to RfC4941 sect. 3.4 this
>> should not happen.
>>
>> Fix this by reparenting orphaned temporary addresses.
>>
>> v2: style fixes
>>
>> Signed-off-by: Heiner Kallweit <heiner.kallweit@web.de>
> Looks good!
>
> Btw. do you intend this as a bugfix for net or net-next? net-next is currently
> closed and you would have to resubmit this patch as soon as net-next opens
> back up. A notification will be send to this list.
>
> Current kernels only print a warning if this happens, so IMHO net-next would
> be ok?
>
> Thanks,
>
> Hannes
>
>
Even though the kernel doesn't fully follow RfC 4941 in this scenario I didn't notice any real harm.
Therefore I would agree and consider it more an improvement than a bugfix. I'll resubmit once net-next is open again.
Regards, Heiner
prev parent reply other threads:[~2014-04-07 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 5:43 [PATCH v2] ipv6: Reparent temporary address(es) if global address was, deleted from userspace Heiner Kallweit
2014-04-07 10:22 ` Hannes Frederic Sowa
2014-04-07 18:50 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5342F378.5030400@web.de \
--to=heiner.kallweit@web.de \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.