From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6204754090721804288 X-Received: by 10.112.16.229 with SMTP id j5mr1239035lbd.6.1444675856433; Mon, 12 Oct 2015 11:50:56 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.180.35.196 with SMTP id k4ls384488wij.24.gmail; Mon, 12 Oct 2015 11:50:56 -0700 (PDT) X-Received: by 10.180.91.233 with SMTP id ch9mr3234957wib.4.1444675856022; Mon, 12 Oct 2015 11:50:56 -0700 (PDT) Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.24]) by gmr-mx.google.com with ESMTPS id c1si567870wiv.3.2015.10.12.11.50.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 11:50:56 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.17.24 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.24; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.227.17.24 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mailfrom=arnd@arndb.de Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0MPp3a-1ZhshZ1z8s-0053mE; Mon, 12 Oct 2015 20:50:55 +0200 From: Arnd Bergmann To: outreachy-kernel@googlegroups.com Cc: Shivani Bhardwaj Subject: Re: [Outreachy kernel] [PATCH v2 1/3] Staging: wilc1000: host_interface: Remove extra NULL test Date: Mon, 12 Oct 2015 20:50:54 +0200 Message-ID: <5343370.v9SSDYu64C@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <3f3303356a62e08e17ffde7cdc8531d5b1fd34bc.1444670615.git.shivanib134@gmail.com> References: <3f3303356a62e08e17ffde7cdc8531d5b1fd34bc.1444670615.git.shivanib134@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GMf/mrQ5s1x1HHmLMgxgaN5mMYcM5d21RWQX2pPhBG1lNdmChZj URwJnfQIOOVtWzlhhGhI8km3GjInvwfZ5TFuWTGnEthnenCe4jDabbRzyMuoF+DxSfAs1hj vYV/BES2S1XnfZ7gSVE8uQgwASxbqEjYHWvXWBnWbluSbt7vV7fQnLXeTJj/N6HsOUmJORZ 8YD0+Ia7Joqyd7CfAy1QA== X-UI-Out-Filterresults: notjunk:1;V01:K0:QDnlXSHZDs4=:j+LzZEX7wYSNVFh8rJ9mIW HiOYKBc0klBA9/KGB+Vt66aNdKExC4OZZL2eurtbZ+/CQgcXJSxsgc0lAznAvnmDF7vf5H+ul 1q7H3urv2jzWhWPTjcPDG/UYvSfIFLnWWn2kocqcMOz5/JRZqBpucZuE2R7RrdbCTKV1/LCSj IjC3u3mowdQRReIYtbw3z+Wur4yOVs7XRICUotwxfuV3Cx1I2SyWgOCycYVjUHynmihUdN5st 2jkUHAmpKSlsusyTFK9TedF/twN453jB1ylavF5vrRnKmkg22fAToQ0RAPaPpVJpXeN87uGMG BKRBGW5I2zMDfSn5EZ83VyEGf+NZvTvzPIj6e510FwSXOutBl/pW/o4kMxTfCGPoZH4Wp+X6f v8MuflQUEBR4+YKWQWFV5pHiW6UMHVf5ExT8QL2LO+XHtswkskVqKiNTQNCPfTcIRJ6OAmqNt j6kpJ2ebJajodW+d+s5VT1BBTF7R7iutTxJCqhAMOPPS9ZSRRBhmIZ13NRNMaCq6zyhaIRWix ZLprfjU58/ysUQWPcA1BW/Y8+jMZv2h2E/cHTENm6rx5pwaK5Dj9dKHA9x0okp7+AxyrjVJFg zYbOmqR3mb0rdrc8/9yKMd8TX/9Xw3QkuN9BUAHIHsyfmcRf33vjFi0ZgX4csymxDZkj+21zF TIMzg5JZlROkj7NuLafIAxYO4PLBXfbuiUMbKL1ZRAOAghweeUCtpYwJY4J2qfGka5dRveUT/ J3r4rWBNfB2wTY15 On Monday 12 October 2015 23:02:01 Shivani Bhardwaj wrote: > Remove NULL test statement as it is preceded by another NULL test on the > same variable in the code. > Issue found using coccinelle. > > Signed-off-by: Shivani Bhardwaj > --- > Changes in v2: > Deleted one patch and added another. Improved the other ones. > drivers/staging/wilc1000/host_interface.c | 3 --- > 1 file changed, 3 deletions(-) In the text above, it makes sense to provide an abbreviated version of the semantic patch when you send something that was generated by coccinelle. > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > index bb833d3..5e4d620 100644 > --- a/drivers/staging/wilc1000/host_interface.c > +++ b/drivers/staging/wilc1000/host_interface.c > @@ -6044,12 +6044,9 @@ s32 host_int_deinit(tstrWILC_WFIDrv *hWFIDrv) > if (ret) > s32Error = -ENOENT; > > - if (pstrWFIDrv != NULL) { > kfree(pstrWFIDrv); > /* pstrWFIDrv=NULL; */ > > - } > - Now the indentation of the kfree() is wrong, it needs to go one tabstop to the left. Also, the comment behind it can be removed in the same patch. Arnd