All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, Eric Sandeen <sandeen@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 00/19] xfs: remove a bunch of unused function args
Date: Mon, 07 Apr 2014 18:43:29 -0500	[thread overview]
Message-ID: <53433821.1080506@sandeen.net> (raw)
In-Reply-To: <20140407232846.GE27017@dastard>

On 4/7/14, 6:28 PM, Dave Chinner wrote:
> On Mon, Apr 07, 2014 at 02:58:47PM -0500, Eric Sandeen wrote:
>> I did some mindless work during a plane ride.  ;)
>>
>> If the granularity of these patches is just too much, I could certainly
>> collapse them into fewer, bigger patches, but I figured that this would
>> make them super-trivial to review.
>>
>> Most have no interesting commit messages aside from the subject, because
>> the subject says it all.
>>
>> Compile-tested only, TBH.
> 
> Looks good, except for the patch I specifically commented on.
> 
> FWIW, this sort of cleanup will help reduce some of the register
> pressure these code paths have, and that in turn will help reduce
> stack usage, so if you can find more...

yep I was thinking along those lines.  I think this is all of them;
more show up w/ GCC warnings but some are for ops that need the superset
of args.  I'll do one more pass to be sure there aren't any knock-on
effects w/ these changes.

Thanks,
-Eric

> Cheers,
> 
> Dave.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2014-04-07 23:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 19:58 [PATCH 00/19] xfs: remove a bunch of unused function args Eric Sandeen
2014-04-07 19:58 ` [PATCH 01/19] xfs: remove unused tp arg from xfs_bmap_last_offset() and callers Eric Sandeen
2014-04-07 19:58 ` [PATCH 02/19] xfs: remove unused mp arg from xfs_attr3_rmt_hdr_ok() Eric Sandeen
2014-04-07 19:58 ` [PATCH 03/19] xfs: remove unused mp arg from xfs_bmdr_maxrecs() Eric Sandeen
2014-04-07 19:58 ` [PATCH 04/19] xfs: remove unused mp arg from xfs_bmap_forkoff_reset() Eric Sandeen
2014-04-07 19:58 ` [PATCH 05/19] xfs: remove unused level arg from xfs_btree_read_buf_block() Eric Sandeen
2014-04-07 19:58 ` [PATCH 06/19] xfs: remove unused blocksize arg from xfs_setsize_buftarg() Eric Sandeen
2014-04-07 19:58 ` [PATCH 07/19] xfs: remove unused args from xfs_alloc_buftarg() Eric Sandeen
2014-04-07 19:58 ` [PATCH 08/19] xfs: remove unused flags arg from _xfs_buf_get_pages() Eric Sandeen
2014-04-07 19:58 ` [PATCH 09/19] xfs: remove unused bip arg from xfs_buf_item_log_segment() Eric Sandeen
2014-04-07 19:58 ` [PATCH 10/19] xfs: remove unused tp arg from xfs_da_reada_buf & callers Eric Sandeen
2014-04-07 19:58 ` [PATCH 11/19] xfs: remove unused mp arg from xfs_dir2 dataptr/byte functions Eric Sandeen
2014-04-07 19:58 ` [PATCH 12/19] xfs: remove unused mp arg from xfs_calc_dquots_per_chunk() Eric Sandeen
2014-04-07 19:59 ` [PATCH 13/19] xfs: remove unused length arg from alloc_block ops Eric Sandeen
2014-04-07 19:59 ` [PATCH 14/19] xfs: remove unused pag ptr arg from iterator execute functions Eric Sandeen
2014-04-07 19:59 ` [PATCH 15/19] xfs: remove unused bp arg from xfs_iflush_fork() Eric Sandeen
2014-04-07 19:59 ` [PATCH 16/19] xfs: remove unused tp arg from xfs_symlink_local_to_remote() Eric Sandeen
2014-04-07 23:23   ` Dave Chinner
2014-04-07 19:59 ` [PATCH 17/19] xfs: remove unused xfs_mount arg from xfs_symlink_hdr_ok() Eric Sandeen
2014-04-07 19:59 ` [PATCH 18/19] xfs: remove unused ail pointer arg from xfs_trans_ail_cursor_done() Eric Sandeen
2014-04-07 19:59 ` [PATCH 19/19] xfs: remove unused trans pointer arg from xlog_recover_unmount_trans() Eric Sandeen
2014-04-07 23:28 ` [PATCH 00/19] xfs: remove a bunch of unused function args Dave Chinner
2014-04-07 23:43   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53433821.1080506@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=david@fromorbit.com \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.