Re: [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for target more nicely

[Chen Gang <gang.chen.5i5j@gmail.com>]

Thanks, and I will/should finish the left trivial patches within this
week (2014-04-13)


On 04/08/2014 03:04 PM, Michael Tokarev wrote:
> From: Chen Gang <gang.chen.5i5j@gmail.com>
> 
> When you ask for an accelerator not supported for your target, you get
> a bogus "accelerator does not exist" message:
> 
>   $ qemu-system-arm -machine none,accel=kvm
>   KVM not supported for this target
>   "kvm" accelerator does not exist.
>   No accelerator found!
> 
> Suppress it.
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  vl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 9975e5a..db9ea90 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2740,7 +2740,7 @@ static int configure_accelerator(QEMUMachine *machine)
>                  if (!accel_list[i].available()) {
>                      printf("%s not supported for this target\n",
>                             accel_list[i].name);
> -                    continue;
> +                    break;
>                  }
>                  *(accel_list[i].allowed) = true;
>                  ret = accel_list[i].init(machine);
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed