From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WXRm1-0005nU-5X for mharc-qemu-trivial@gnu.org; Tue, 08 Apr 2014 04:52:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRlt-0005fm-86 for qemu-trivial@nongnu.org; Tue, 08 Apr 2014 04:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXRlo-0006nH-5h for qemu-trivial@nongnu.org; Tue, 08 Apr 2014 04:52:45 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:55592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRld-0006m4-LZ; Tue, 08 Apr 2014 04:52:29 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 2489840E7E; Tue, 8 Apr 2014 12:52:27 +0400 (MSK) Message-ID: <5343B8CB.9050700@msgid.tls.msk.ru> Date: Tue, 08 Apr 2014 12:52:27 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Peter Maydell References: <1396940651-10513-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: X-Enigmail-Version: 1.5.1 OpenPGP: id=804465C5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: QEMU Trivial , QEMU Developers Subject: Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Apr 2014 08:52:50 -0000 08.04.2014 12:10, Peter Maydell wrote: > On 8 April 2014 08:04, Michael Tokarev wrote: >> And there's a series of 3 patches by Peter Maydell which adds casts >> to uint* in a few places. Those are also quite simple and safe, even >> with quite some disagreement about whenever this is necessary to >> start with -- I mean the int128 change, the other changes are good. >> At least this way we make it consistent with other parts of the code. > > I was not expecting those to go in for 2.0... Well. At least one of them is entirely safe (hw/ide/ahci.c). Another - xbzrle.c - looks okay, and even maybe fixing a bug. And this int128 thing is okay too, except that the whole thing is questionable as has been mentioned in that thread. I can prepare another pull request without xbzrle and int128 changes, or even without ahci change too, but I'm not sure it is worth the effort - I think everything is okay to go. I'll take your word for this. Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRli-0005VW-RF for qemu-devel@nongnu.org; Tue, 08 Apr 2014 04:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXRld-0006mC-T0 for qemu-devel@nongnu.org; Tue, 08 Apr 2014 04:52:34 -0400 Message-ID: <5343B8CB.9050700@msgid.tls.msk.ru> Date: Tue, 08 Apr 2014 12:52:27 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1396940651-10513-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , QEMU Developers 08.04.2014 12:10, Peter Maydell wrote: > On 8 April 2014 08:04, Michael Tokarev wrote: >> And there's a series of 3 patches by Peter Maydell which adds casts >> to uint* in a few places. Those are also quite simple and safe, even >> with quite some disagreement about whenever this is necessary to >> start with -- I mean the int128 change, the other changes are good. >> At least this way we make it consistent with other parts of the code. > > I was not expecting those to go in for 2.0... Well. At least one of them is entirely safe (hw/ide/ahci.c). Another - xbzrle.c - looks okay, and even maybe fixing a bug. And this int128 thing is okay too, except that the whole thing is questionable as has been mentioned in that thread. I can prepare another pull request without xbzrle and int128 changes, or even without ahci change too, but I'm not sure it is worth the effort - I think everything is okay to go. I'll take your word for this. Thanks, /mjt