From: ZhangZhen <zhenzhang.zhang@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <tytso@mit.edu>, Jan Kara <jack@suse.cz>, <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: check the acl's validity before setting
Date: Tue, 8 Apr 2014 16:59:48 +0800 [thread overview]
Message-ID: <5343BA84.3090905@huawei.com> (raw)
In-Reply-To: <20140408054625.GA28818@infradead.org>
On 2014/4/8 13:46, Christoph Hellwig wrote:
> On Tue, Apr 08, 2014 at 10:02:50AM +0800, ZhangZhen wrote:
>> Before setting the acl, call posix_acl_valid() to check if it is
>> valid or not.
>
> Why? posix_acl_xattr_set already does that for you, and it's the only
> way to feed in an ACL from userspace.
>
>
>
Hi Hellwig,
You are right, this patch is useless. I'm sorry for this spam mail.
But btrfs_set_acl checks the validity of the ACL too. Should we delete it?
Another choice is we can check the validity in every fs tree, and delete the
check from posix_acl_xattr_set.
How should we do?
Thanks!
next prev parent reply other threads:[~2014-04-08 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1396922063-4879-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-04-08 2:02 ` [PATCH] ext4: check the acl's validity before setting ZhangZhen
2014-04-08 5:46 ` Christoph Hellwig
2014-04-08 8:59 ` ZhangZhen [this message]
2014-04-08 10:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343BA84.3090905@huawei.com \
--to=zhenzhang.zhang@huawei.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.