All of lore.kernel.org
 help / color / mirror / Atom feed
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
Date: Tue, 8 Apr 2014 12:07:17 +0300	[thread overview]
Message-ID: <5343BC45.5090205@ti.com> (raw)
In-Reply-To: <5342E575.60308@ti.com>

On 04/07/2014 08:50 PM, Santosh Shilimkar wrote:
> On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote:
>> I2C nodes should always have #address-cells and #size-cells defined.
>> Hence, ensure that all i2cX nodes have #address-cells and #size-cells
>> properties defined.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
> Right. BTW, have you seen some issue without this patch ?
> Just curious what prompted you to create this patch and whether
> it needs to be sent as fix during rc's.

I think, it can wait for next. Without this patch warnings will
be produced in case of adding child node to the bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c at 2530800/pca at 20
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c at 2530800/pca at 20

I'll updated patch description and resend.

Regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
To: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
Date: Tue, 8 Apr 2014 12:07:17 +0300	[thread overview]
Message-ID: <5343BC45.5090205@ti.com> (raw)
In-Reply-To: <5342E575.60308-l0cyMroinI0@public.gmane.org>

On 04/07/2014 08:50 PM, Santosh Shilimkar wrote:
> On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote:
>> I2C nodes should always have #address-cells and #size-cells defined.
>> Hence, ensure that all i2cX nodes have #address-cells and #size-cells
>> properties defined.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
>> ---
> Right. BTW, have you seen some issue without this patch ?
> Just curious what prompted you to create this patch and whether
> it needs to be sent as fix during rc's.

I think, it can wait for next. Without this patch warnings will
be produced in case of adding child node to the bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c@2530800/pca@20
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c@2530800/pca@20

I'll updated patch description and resend.

Regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-04-08  9:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 15:24 [PATCH] ARM: dts: keystone: add cell's information to i2c nodes Grygorii Strashko
2014-04-07 15:24 ` Grygorii Strashko
2014-04-07 17:50 ` Santosh Shilimkar
2014-04-07 17:50   ` Santosh Shilimkar
2014-04-08  9:07   ` Grygorii Strashko [this message]
2014-04-08  9:07     ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5343BC45.5090205@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.